Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remote publication using min node version for backward compatibility #15216

Merged
merged 7 commits into from
Aug 30, 2024
Merged

Remote publication using min node version for backward compatibility #15216

merged 7 commits into from
Aug 30, 2024

Conversation

soosinha
Copy link
Member

@soosinha soosinha commented Aug 13, 2024 •
edited
Loading

Description

  • Remote cluster state state should be published using min node version in the cluster. If even a single node is not remote enabled then remote publication should not be used.

Related Issues

NA

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@soosinha soosinha changed the title Consistent remote publication Remote publication using min node version for backward compatibility Aug 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 0c18070: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@soosinha soosinha force-pushed the consistent-remote-publication branch 2 times, most recently from 09cae0e to f7fec95 Compare August 14, 2024 11:48
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 09cae0e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for f7fec95: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 363e892: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@soosinha soosinha force-pushed the consistent-remote-publication branch from 363e892 to 7fdd155 Compare August 15, 2024 12:01
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 7fdd155: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@soosinha soosinha marked this pull request as ready for review August 16, 2024 04:54
@shwetathareja
Copy link
Member

please add changelog as well

@soosinha soosinha force-pushed the consistent-remote-publication branch 2 times, most recently from 0fd4c9d to 482cac4 Compare August 29, 2024 12:16
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 0fd4c9d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 482cac4: SUCCESS

@soosinha soosinha added the backport 2.x Backport to 2.x branch label Aug 29, 2024
@soosinha
Publish remote state using min node version
4e91759 
Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
@soosinha
Add unit tests for codec version
9de189e 
Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
@soosinha
Add RemotePersistedState unit tests
f0c5c1f 
Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
@soosinha
Auto-generate version to codec mapping
e1d35fd 
Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
@soosinha
Add assert for codec version
7b31acc 
Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
@soosinha
Add version check again for full cluster state upload
7ccdc33 
Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
@soosinha
Add assert for max codec version
1f425a1 
Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
@soosinha soosinha force-pushed the consistent-remote-publication branch from 482cac4 to 1f425a1 Compare August 29, 2024 16:51
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 1f425a1: SUCCESS

@shwetathareja shwetathareja merged commit cad81b0 into opensearch-project:main Aug 30, 2024
35 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 30, 2024
@github-actions
Remote publication using min node version for backward compatibility (#…
e6dd426 
…15216)

* Publish remote state using min node version

Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
(cherry picked from commit cad81b0)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Aug 30, 2024
Merged
shwetathareja pushed a commit that referenced this pull request Aug 30, 2024
@opensearch-trigger-bot @github-actions
Remote publication using min node version for backward compatibility (#…
e71bec3 
…15216) (#15522)

* Publish remote state using min node version


(cherry picked from commit cad81b0)

Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Bukhtawar
Bukhtawar reviewed Sep 3, 2024
View reviewed changes
server/src/main/java/org/opensearch/cluster/coordination/PublicationTransportHandler.java
Comment on lines +337 to +348
if (isRemotePublicationEnabled == true) {
if (allNodesRemotePublicationEnabled.get() == false) {
if (validateRemotePublicationOnAllNodes(clusterChangedEvent.state().nodes()) == true) {
allNodesRemotePublicationEnabled.set(true);
}
}
if (allNodesRemotePublicationEnabled.get() == true) {
// if all nodes are remote then create remote publication context
return new RemotePublicationContext(clusterChangedEvent, persistedStateRegistry);
}
}
final PublicationContext publicationContext = new PublicationContext(clusterChangedEvent, persistedStateRegistry);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry why is this needed. Can we publish cluster state dual mode based on the destination node attribute?

akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
@soosinha @akolarkunnu
Remote publication using min node version for backward compatibility (o…
33e8fe4 
…pensearch-project#15216)

* Publish remote state using min node version

Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Sep 11, 2024
Open
@BrewTestBot BrewTestBot mentioned this pull request Sep 18, 2024
Merged
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
@soosinha @dk2k
Remote publication using min node version for backward compatibility (o…
b8d6dff 
…pensearch-project#15216)

* Publish remote state using min node version

Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
@soosinha @dk2k
Remote publication using min node version for backward compatibility (o…
77762a2 
…pensearch-project#15216)

* Publish remote state using min node version

Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
@soosinha soosinha mentioned this pull request Oct 21, 2024
Merged
3 tasks
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
@soosinha @dk2k
Remote publication using min node version for backward compatibility (o…
0998191 
…pensearch-project#15216)

* Publish remote state using min node version

Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bukhtawar Bukhtawar Bukhtawar left review comments

@himshikha himshikha himshikha left review comments

@shwetathareja shwetathareja shwetathareja approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@soosinha @shwetathareja @himshikha @Bukhtawar