Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote publication using min node version for backward compatibility #15216

Merged

Conversation

soosinha
Copy link
Member

@soosinha soosinha commented Aug 13, 2024

Description

  • Remote cluster state state should be published using min node version in the cluster. If even a single node is not remote enabled then remote publication should not be used.

Related Issues

NA

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@soosinha soosinha changed the title Consistent remote publication Remote publication using min node version for backward compatibility Aug 13, 2024
Copy link
Contributor

❌ Gradle check result for 0c18070: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@soosinha soosinha force-pushed the consistent-remote-publication branch 2 times, most recently from 09cae0e to f7fec95 Compare August 14, 2024 11:48
Copy link
Contributor

❌ Gradle check result for 09cae0e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for f7fec95: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 363e892: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@soosinha soosinha force-pushed the consistent-remote-publication branch from 363e892 to 7fdd155 Compare August 15, 2024 12:01
Copy link
Contributor

❌ Gradle check result for 7fdd155: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@shwetathareja
Copy link
Member

please add changelog as well

@soosinha soosinha force-pushed the consistent-remote-publication branch 2 times, most recently from 0fd4c9d to 482cac4 Compare August 29, 2024 12:16
Copy link
Contributor

❌ Gradle check result for 0fd4c9d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 482cac4: SUCCESS

@soosinha soosinha added the backport 2.x Backport to 2.x branch label Aug 29, 2024
Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
@soosinha soosinha force-pushed the consistent-remote-publication branch from 482cac4 to 1f425a1 Compare August 29, 2024 16:51
Copy link
Contributor

✅ Gradle check result for 1f425a1: SUCCESS

@shwetathareja shwetathareja merged commit cad81b0 into opensearch-project:main Aug 30, 2024
35 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 30, 2024
…15216)

* Publish remote state using min node version

Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
(cherry picked from commit cad81b0)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
shwetathareja pushed a commit that referenced this pull request Aug 30, 2024
…15216) (#15522)

* Publish remote state using min node version


(cherry picked from commit cad81b0)

Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Comment on lines +337 to +348
if (isRemotePublicationEnabled == true) {
if (allNodesRemotePublicationEnabled.get() == false) {
if (validateRemotePublicationOnAllNodes(clusterChangedEvent.state().nodes()) == true) {
allNodesRemotePublicationEnabled.set(true);
}
}
if (allNodesRemotePublicationEnabled.get() == true) {
// if all nodes are remote then create remote publication context
return new RemotePublicationContext(clusterChangedEvent, persistedStateRegistry);
}
}
final PublicationContext publicationContext = new PublicationContext(clusterChangedEvent, persistedStateRegistry);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry why is this needed. Can we publish cluster state dual mode based on the destination node attribute?

akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
…pensearch-project#15216)

* Publish remote state using min node version

Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
…pensearch-project#15216)

* Publish remote state using min node version

Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
…pensearch-project#15216)

* Publish remote state using min node version

Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
…pensearch-project#15216)

* Publish remote state using min node version

Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants