-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remote publication using min node version for backward compatibility #15216
Remote publication using min node version for backward compatibility #15216
Conversation
❌ Gradle check result for 0c18070: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/gateway/remote/RemoteClusterStateService.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/cluster/coordination/PublicationTransportHandler.java
Outdated
Show resolved
Hide resolved
09cae0e
to
f7fec95
Compare
❌ Gradle check result for 09cae0e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for f7fec95: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 363e892: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
363e892
to
7fdd155
Compare
❌ Gradle check result for 7fdd155: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
please add changelog as well |
0fd4c9d
to
482cac4
Compare
❌ Gradle check result for 0fd4c9d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/gateway/remote/ClusterMetadataManifest.java
Show resolved
Hide resolved
Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
482cac4
to
1f425a1
Compare
…15216) (#15522) * Publish remote state using min node version (cherry picked from commit cad81b0) Signed-off-by: Sooraj Sinha <soosinha@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
if (isRemotePublicationEnabled == true) { | ||
if (allNodesRemotePublicationEnabled.get() == false) { | ||
if (validateRemotePublicationOnAllNodes(clusterChangedEvent.state().nodes()) == true) { | ||
allNodesRemotePublicationEnabled.set(true); | ||
} | ||
} | ||
if (allNodesRemotePublicationEnabled.get() == true) { | ||
// if all nodes are remote then create remote publication context | ||
return new RemotePublicationContext(clusterChangedEvent, persistedStateRegistry); | ||
} | ||
} | ||
final PublicationContext publicationContext = new PublicationContext(clusterChangedEvent, persistedStateRegistry); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry why is this needed. Can we publish cluster state dual mode based on the destination node attribute?
…pensearch-project#15216) * Publish remote state using min node version Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
…pensearch-project#15216) * Publish remote state using min node version Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
…pensearch-project#15216) * Publish remote state using min node version Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
…pensearch-project#15216) * Publish remote state using min node version Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
Description
Related Issues
NA
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.