Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote State] Disable remote publication if remote state disabled #15219

Merged
merged 2 commits into from
Aug 25, 2024

Conversation

shiv0408
Copy link
Member

Description

Fall back to legacy Transport publication if Remote State is disabled. We were earlier trying to use remote publication when remote state was disabled, as the remote state was disabled RemoteClusterStateService instance is null and we were hitting null pointer.

Related Issues

Resolves #15182

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for c240d50: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for f23b757: SUCCESS

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.87%. Comparing base (f94a99e) to head (a6e78ed).
Report is 16 commits behind head on main.

Files Patch % Lines
...search/cluster/coordination/CoordinationState.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               main   #15219    +/-   ##
==========================================
  Coverage     71.86%   71.87%            
+ Complexity    63227    63168    -59     
==========================================
  Files          5213     5213            
  Lines        295780   295781     +1     
  Branches      42725    42726     +1     
==========================================
+ Hits         212568   212598    +30     
+ Misses        65842    65724   -118     
- Partials      17370    17459    +89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Copy link
Contributor

❌ Gradle check result for 9ab68d7: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 9b47d5b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Copy link
Contributor

❌ Gradle check result for a6e78ed: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@shiv0408
Copy link
Member Author

❌ Gradle check result for a6e78ed: FAILURE

Test is flaky
org.opensearch.cluster.service.MasterServiceTests.testClusterStateUpdateLoggingWithDebugEnabled - #15117

Copy link
Contributor

❕ Gradle check result for a6e78ed: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@Bukhtawar Bukhtawar merged commit 689cfca into opensearch-project:main Aug 25, 2024
33 of 34 checks passed
@Bukhtawar Bukhtawar added the backport 2.x Backport to 2.x branch label Aug 25, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 25, 2024
…15219)

* Disable remote publication if remote state disabled

Signed-off-by: Shivansh Arora <hishiv@amazon.com>
(cherry picked from commit 689cfca)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dblock pushed a commit that referenced this pull request Aug 25, 2024
…15219) (#15402)

* Disable remote publication if remote state disabled


(cherry picked from commit 689cfca)

Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@shiv0408 shiv0408 deleted the remote-state-disable branch August 26, 2024 05:10
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
…pensearch-project#15219)

* Disable remote publication if remote state disabled

Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch bug Something isn't working Cluster Manager skip-changelog
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[Remote State] NullPointerException when remote publication enabled with remote state disabled
4 participants