Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Add Create QueryGroup API Logic (#14680) #15227

Merged
merged 1 commit into from
Aug 16, 2024
Merged

[Backport 2.x] Add Create QueryGroup API Logic (#14680) #15227

merged 1 commit into from
Aug 16, 2024

Conversation

jainankitk
Copy link
Collaborator

Backports #14680

@ruai0511 @jainankitk
Add Create QueryGroup API Logic (opensearch-project#14680)
79a1cb5 
* add logic for Create QueryGroup API
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>

* remove wildcard imports
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>

* change jvm to memeory
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>

* modify querygroup
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>

* fix javadoc and add more tests
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>

* add more tests
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>

* address comments
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>

* fix the persist logic
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>

* remove inflight checks as they are not necessary
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>

* remove persistable interface
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>

* modify QueryGroupServiceSettings
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>

* add in an action package in the plugin
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>

* modify based on commments
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>

* address comments on QueryGroupPersistenceService
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>

* address comments on persistence service
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>

* address comments
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>

* fix unit test
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>

* address comments
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>

* add IT
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>

* add coverage
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>
(cherry picked from commit d442f7c)
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 79a1cb5: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Aug 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 74.50980% with 39 lines in your changes missing coverage. Please review.

Project coverage is 71.56%. Comparing base (2e6c5de) to head (79a1cb5).
Report is 10 commits behind head on 2.x.

Files Patch % Lines
...va/org/opensearch/cluster/metadata/QueryGroup.java 75.55% 4 Missing and 7 partials ⚠️
...ch/plugin/wlm/rest/RestCreateQueryGroupAction.java 0.00% 8 Missing ⚠️
...in/wlm/action/TransportCreateQueryGroupAction.java 0.00% 7 Missing ⚠️
...pensearch/plugin/wlm/WorkloadManagementPlugin.java 0.00% 4 Missing ⚠️
...arch/plugin/wlm/action/CreateQueryGroupAction.java 0.00% 3 Missing ⚠️
...rch/plugin/wlm/action/CreateQueryGroupRequest.java 76.92% 3 Missing ⚠️
...ugin/wlm/service/QueryGroupPersistenceService.java 94.64% 1 Missing and 2 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #15227      +/-   ##
============================================
+ Coverage     71.49%   71.56%   +0.06%     
- Complexity    62809    62835      +26     
============================================
  Files          5138     5145       +7     
  Lines        295078   295187     +109     
  Branches      42980    42989       +9     
============================================
+ Hits         210980   211260     +280     
+ Misses        66459    66195     -264     
- Partials      17639    17732      +93

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jainankitk jainankitk mentioned this pull request Aug 16, 2024
Merged
8 tasks
@jed326 jed326 merged commit 1bee506 into opensearch-project:2.x Aug 16, 2024
55 of 56 checks passed
@jed326 jed326 changed the title Add Create QueryGroup API Logic (#14680) [Backport 2.x] Add Create QueryGroup API Logic (#14680) Aug 16, 2024
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Sep 11, 2024
Open
@jainankitk jainankitk deleted the backport/backport-14680-to-2.x branch February 12, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jed326 jed326 jed326 approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jainankitk @jed326 @ruai0511