fix: MinHash token filter parameters not working

[mridehalgh]

Description

The MinHash token filter has four configurable parameters: bucket_count, hash_count, hash_set_size, and with_rotation. Currently both bucket_count and hash_set_size have no effect, because there appears to be a bug in the code that interfaces with the underlying Lucene class.

Notice the camel-case bucketCount and hashSetSize in the hasValue lines. These should be bucket_count and hash_set_size, since those are the parameter names that would appear (and be fetched on the following lines) from the settings object.

Related Issues

Resolves #15183

Check List

• Functionality includes testing.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

❌ Gradle check result for 83afab7: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 59dc3d8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[dblock]

Thank you! Would you be able to check that this (and maybe other) token filter(s) are present in https://github.com/opensearch-project/opensearch-api-specification and add a test for this one in that repo?

Do update CHANGELOG in this PR, this is a bug fix.

[github-actions]

✅ Gradle check result for 423b829: SUCCESS

[dblock]

Needs a CHANGELOG update, thx.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.89%. Comparing base (cbe7921) to head (3905dc3).
Report is 2 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #15233      +/-   ##
============================================
+ Coverage     71.82%   71.89%   +0.06%     
- Complexity    63046    63103      +57     
============================================
  Files          5207     5207              
  Lines        295581   295581              
  Branches      42690    42690              
============================================
+ Hits         212295   212495     +200     
+ Misses        65875    65689     -186     
+ Partials      17411    17397      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mridehalgh]

Needs a CHANGELOG update, thx.

@dblock - thanks for the quick feedback. Added changelog entry.

[github-actions]

❕ Gradle check result for e6a3822: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[github-actions]

❌ Gradle check result for 3df3b0b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 3df3b0b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

✅ Gradle check result for 3df3b0b: SUCCESS

[dblock]

Thank you! Would you be able to check that this (and maybe other) token filter(s) are present in https://github.com/opensearch-project/opensearch-api-specification and add a test for this one in that repo?

@mridehalgh while this is getting rebased, care to take a look at ^ ?

[github-actions]

❌ Gradle check result for 26993dc: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 26993dc: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[dblock]

❌ Gradle check result for 26993dc: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

I don't understand why this failed. @mridehalgh care to rebase to get the latest?

[mridehalgh]

❌ Gradle check result for 26993dc: FAILURE
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

I don't understand why this failed. @mridehalgh care to rebase to get the latest?

@dblock neither do I. Rebasing :)

[github-actions]

✅ Gradle check result for 3905dc3: SUCCESS

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15233-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9661e8db62e8897cb53b0bc1860ead43b28dfa21
# Push it to GitHub
git push --set-upstream origin backport/backport-15233-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-15233-to-2.x.

[dblock]

@mridehalgh Looks like it will need a manual backport to 2.x please?