Star Tree Merge and Aggregation Fixes #15274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
sarthakaggarwal97
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
...r/src/test/java/org/opensearch/index/compositeindex/datacube/startree/StarTreeTestUtils.java
Outdated
Show resolved
Hide resolved
.../java/org/opensearch/index/compositeindex/datacube/startree/aggregators/ValueAggregator.java
Show resolved
Hide resolved
bharath-techie
approved these changes
Aug 16, 2024
.../java/org/opensearch/index/compositeindex/datacube/startree/builder/BaseStarTreeBuilder.java
Show resolved
Hide resolved
mgodwan
reviewed
Aug 16, 2024
...r/src/test/java/org/opensearch/index/compositeindex/datacube/startree/StarTreeTestUtils.java
Outdated
Show resolved
Hide resolved
mgodwan
reviewed
Aug 16, 2024
...r/src/test/java/org/opensearch/index/compositeindex/datacube/startree/StarTreeTestUtils.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
|
addressed comments @bharath-techie @mgodwan, please take a look. |
.../opensearch/index/compositeindex/datacube/startree/builder/AbstractStarTreeBuilderTests.java
Show resolved
Hide resolved
bharath-techie
approved these changes
Aug 16, 2024
sarthakaggarwal97
force-pushed
the
startree-merge-agg-fix
branch
2 times, most recently
from
05ee1f5 to
8d27f50
Compare
mgodwan
approved these changes
Aug 16, 2024
|
❌ Gradle check result for 8d27f50: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❕ Gradle check result for 05ee1f5: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
.../opensearch/index/compositeindex/datacube/startree/builder/AbstractStarTreeBuilderTests.java
Show resolved
Hide resolved
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
sarthakaggarwal97
force-pushed
the
startree-merge-agg-fix
branch
from
8d27f50 to
90cc4ef
Compare
Not able to understand much from the PR description. Can you please re-word this? |
.../opensearch/index/compositeindex/datacube/startree/builder/AbstractStarTreeBuilderTests.java
Show resolved
Hide resolved
sachinpkale
approved these changes
Aug 19, 2024
ajaymovva
approved these changes
Aug 19, 2024
wdongyu
pushed a commit
to wdongyu/OpenSearch
that referenced
this pull request
Aug 22, 2024
--------- Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 26, 2024
--------- Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> (cherry picked from commit a27d26b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
linuxpi
pushed a commit
that referenced
this pull request
Aug 26, 2024
--------- (cherry picked from commit a27d26b) Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
akolarkunnu
pushed a commit
to akolarkunnu/OpenSearch
that referenced
this pull request
Sep 10, 2024
--------- Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Coming here from #14809.
Whenever we were reading the star tree documents from the segment during merges, we were transforming the segment metric doc value to its original field type. Instead, it should be converted to aggregator value type since before indexing doc values, the metric type is of the aggregator value type.
For Example.
If there is a Half Float Metric Field, with the SUM metric (double type). The Half Float Metric field is converted to double during aggregation and indexed as "double". During reads, the metric should be converted from sortable long back to double only for accurate aggregations.
Related Issues
Resolves #15275
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.