-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Remote Publication] Add remote download stats #15291
[Remote Publication] Add remote download stats #15291
Conversation
268258a
to
52aaa2f
Compare
❌ Gradle check result for 268258a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
52aaa2f
to
5d1f7cb
Compare
❌ Gradle check result for 52aaa2f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 5d1f7cb: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"indices_routing_diff_files_cleanup_attempt_failed_count": 0,
"index_routing_files_cleanup_attempt_failed_count": 0,
The above stats looks out of place
Agree, these are added as part of these PR: #13909 #14684 . Should we create an issue to track this? @Bukhtawar |
server/src/main/java/org/opensearch/gateway/remote/RemoteClusterStateService.java
Outdated
Show resolved
Hide resolved
5d1f7cb
to
4791e2b
Compare
❌ Gradle check result for 4791e2b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/gateway/remote/RemoteDownloadStats.java
Outdated
Show resolved
Hide resolved
❌ Gradle check result for 5994e9c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/gateway/remote/RemoteDownloadStats.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/cluster/coordination/CoordinationState.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/cluster/coordination/Coordinator.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/cluster/coordination/PublicationTransportHandler.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/cluster/coordination/PublicationTransportHandler.java
Outdated
Show resolved
Hide resolved
❌ Gradle check result for f6d1b5a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
f6d1b5a
to
28ab454
Compare
❌ Gradle check result for 28ab454: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
28ab454
to
faaece8
Compare
❌ Gradle check result for faaece8: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
faaece8
to
b8f74ee
Compare
Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
b9125bf
to
e6bf8db
Compare
❌ Gradle check result for e6bf8db: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
e6bf8db
to
a1a6b82
Compare
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15291-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b54e867da0e313513e90872e039717b7595cf6e4
# Push it to GitHub
git push --set-upstream origin backport/backport-15291-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
) --------- Signed-off-by: Arpit Bandejiya <abandeji@amazon.com> (cherry picked from commit b54e867)
) --------- Signed-off-by: Arpit Bandejiya <abandeji@amazon.com> (cherry picked from commit b54e867)
) --------- Signed-off-by: Arpit Bandejiya <abandeji@amazon.com> (cherry picked from commit b54e867)
) --------- Signed-off-by: Arpit Bandejiya <abandeji@amazon.com> (cherry picked from commit b54e867)
Description
This PR introduces the remote download stats for the remote publication.
Sample stats on master node:
Sample stats on data node:
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.