Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed unused StringBuilder #15360

Closed
wants to merge 3 commits into from
Closed

Removed unused StringBuilder #15360

wants to merge 3 commits into from

Conversation

dk2k
Copy link
Contributor

@dk2k dk2k commented Aug 22, 2024

Removed unused StringBuilder

@dk2k
Removed unused StringBuilder
89bb746 
Signed-off-by: Dmitry Kryukov <dk2k@mail.ru>
dk2k added 2 commits August 22, 2024 21:14
@dk2k
Removed unused StringBuilder
b3b37ba 
Signed-off-by: Dmitry Kryukov <dk2k@mail.ru>
Signed-off-by: Dmitry Kryukov <dk2k@ya.ru>
@dk2k
Merge remote-tracking branch 'origin/dk_remove_unused_strbuilder' int…
c8afff2 
…o dk_remove_unused_strbuilder
@dk2k dk2k marked this pull request as draft August 22, 2024 18:18
@github-actions GitHub Actions
Copy link
Contributor

❕ Gradle check result for 89bb746: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for c8afff2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@dblock
Copy link
Member

dblock commented Aug 23, 2024

I bet you the intent of this toString was to actually use this StringBulder. Check whether we have a test for this and fix?

@dblock dblock mentioned this pull request Aug 23, 2024
Merged
This was referenced Sep 11, 2024
Open
Open
Open
@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added the stalled Issues that have stalled label Sep 23, 2024
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Sep 24, 2024
Open
@prudhvigodithi prudhvigodithi mentioned this pull request Oct 16, 2024
Open
@dbwiddis
Copy link
Member

Closing as this is duplicated by #15362 which has discussion

@dbwiddis dbwiddis closed this Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
stalled Issues that have stalled
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dk2k @dblock @dbwiddis