-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Array, passed to Objects.hash(), should be wrapped into Arrays.hashCode() #15383
Closed
Closed
Changes from 1 commit
Commits
Show all changes
307 commits
Select commit
Hold shift + click to select a range
96ceaf8
Fix flaky tests with hashed prefix path type snapshots (#15560)
ashking94 28fd494
Modify create snapshot response when wait_for_completion is false (#1…
anshu1106 d596298
[Remote Publication] Add remote download stats (#15291)
Arpit-Bandejiya ecf248a
Star Tree File Formats (#14809)
sarthakaggarwal97 b95bd5f
Simplify diff calculation for remote routing table (#15100)
Bukhtawar 538e33f
Update version check for context to comply with backport (#15572)
mgodwan cb2ff68
Introduce ApproximateRangeQuery and ApproximateQuery (#13788)
harshavamsi 5482f25
Change pinned timestamp file format stored in remote store (#15526)
sachinpkale 527cd58
Add limit on number of processors in Ingest pipelines (#15465)
anandkrrai 5ac608d
[SnapshotV2] Snapshot Status API changes (#15409)
ltaragi ec92899
Fix missing order field in TemplatesMetadata deserialization (#15509)
soosinha fd82d4a
Support cancellation for admin apis (#13966)
aasom143 890d189
Fix flaky test MasterServiceTests.testClusterStateUpdateLoggingWithDe…
sumitasr 0688d52
Disable pinned timestamp flag and mute testRemoteStoreCleanupForDelet…
sachinpkale 0cd2c04
Adding awaitsFix to approximateRangeTest flaky tests (#15601)
bharath-techie cde0822
[Star tree] Star tree index validations (#15533)
bharath-techie 5ee411b
Add prefix support to hashed prefix & infix path types on remote stor…
ashking94 8c0cb5c
[Snapshot V2] Fix for create snapshot build and test failures (#15602)
anshu1106 6d7f785
Change version to V_2_17_0 (#15596)
ltaragi f7e15e0
Add cluster state checksum in manifest (#15218)
himshikha 41e7343
Restore snapshot changes for shallow snapshot V2 (#15462)
sachinpkale eb80bc8
Limiting node attribute serialisation in DiscoveryNode (#15341)
RS146BIJAY 224cc1b
interfaces fixes for star tree search (#15603)
sarthakaggarwal97 658c5ee
SnapshotInfo pinned timestamp version change to V_2_17_0 (#15616)
anshu1106 30ba949
Abstract out RemoteFsTranslogWithPinnedTimestamps (#15579)
sachinpkale 533c356
Optimise snapshot deletion to speed up snapshot deletion and creation…
ashking94 7805fa3
Remove breaking changes from #15409 (#15624)
ltaragi 12650ae
Add canRemain method to TargetPoolAllocationDecider to move shards fr…
neetikasinghal 93b93f4
pluggable deciders for concurrent search (#15363)
Gankris96 04b2f74
Fixing OpenSearch API Spec annotation build errors (#15626)
saratvemulapalli 451396a
Fix flaky test in 91_flat_object_null_value.yml (#15545)
msfroh 5a34f06
Revert "Add fieldType to AbstractQueryBuilder and SortBuilder (#15328…
jainankitk 11a70eb
Add Update QueryGroup API Logic (#14775)
ruai0511 308d9a7
[Snapshot V2] Support pinned timestamp in delete flow (#15256)
anshu1106 1de15b2
ClusterManagerTaskThrottler Improvements (#15508)
sumitasr 9c9502e
Changing checksum setting to support modes (#15622)
himshikha d717748
Fix version check for BWC of Discovery Node serialization (#15620)
RS146BIJAY db0e04f
Initialise RemoteRoutingTableService when we have RoutingTable reposi…
shiv0408 3d5bd2d
Reset discovery nodes in most transport node actions request. (#15131)
SwethaGuptha 5228ea9
Mute failing snapshot status tests (#15652)
ltaragi 1aeb9e8
[Star Tree] Scaled Float Support (#15442)
sarthakaggarwal97 2c81465
Optimizing get indices to segments map calculations for IndicesSegmen…
gargharsh3134 02f0f68
relaxing the join validation for nodes which have only store disabled…
rajiv-kv d2fc795
Set Version to 2.17 for hashed prefix snapshots (#15656)
ashking94 92493f2
fix wildcard term & terms query & add YAML REST test (#15607)
HUSTERGS 28edfd7
Fix approximate pointrangequery tests (#15590)
harshavamsi 64d3a5c
[Star tree][Bug] Fix for derived metrics (#15640)
bharath-techie 68c5ed6
[RW Separation] Add routing preference to route requests only to sear…
mch2 2d04461
Integrate translog cleanup with snapshot deletion and fix primary ter…
sachinpkale e6e37d7
[RW Separation] Introduce allocation filter to control placement of s…
mch2 43e3b71
Add new cluster setting for keyword indexordocvalues query (#15637)
harshavamsi eaf4553
Fix bwc test failures by updating wire compatibility on NodeIndicesSt…
mch2 f351fa9
Mute test testRemoteStoreCleanupForDeletedIndexForSnapshotV2 (#15695)
mch2 d077c54
[RW Separation] Add polling segment replication for search replicas (…
mch2 c6e6a78
version change to V_2.17.0 for node min version check (#15644)
anshu1106 7093e28
Throw CircuitBreakingException for too many shards in snashot status …
ltaragi d8a118e
Schedule reroute after allocator timed out (#15565)
imRishN d83dc35
Add dedicated string prefix for remote index metadata and remote rout…
soosinha a82e87e
Fix MacOS assemble workflows (#15741)
reta 581052d
Add 2.18.0 version (#15712)
reta 575294b
Provide factory for pluggable deciders (#15713)
Gankris96 4ae3746
Update newQueryShardContext() overload to fix breaking changes (#15710)
harshavamsi 8d47946
Making _cat/allocation API use indexLevelStats (#15292)
gargharsh3134 64ee69e
Integ Test for RemotePublication can be disabled by rolling restart o…
shiv0408 b0040b5
Bump com.azure:azure-identity from 1.13.0 to 1.13.2 in /plugins/repos…
dependabot[bot] 60e35e0
Add path prefix support to hashed prefix snapshots (#15664)
ashking94 03bd186
Adding WithFieldName interface for QueryBuilders with fieldName (#15705)
dzane17 91285a8
Mitigation for remote snapshot filecache overflow (#15077)
finnegancarroll 3e9e557
Mute flaky test RemoteFsTimestampAwareTranslogTests.testSimpleOperati…
sachinpkale 122fbcb
Fixing MacOS 13 assemble workflows (#15747)
reta 179fc54
Make Remote Publication a static setting (#15478)
shiv0408 0c34a74
Mute flaky test testRemotePublicationDisabledByRollingRestart (#15772)
shiv0408 9bb19cf
[Snapshot V2] Support pinned timestamp in clone flow (#15524)
anshu1106 b9e029b
Add wait in replica recovery for allocation id to propagate on source…
gbbafna e5eb716
[Remote State] Upload incremental cluster state on master re-election…
shiv0408 74f7d59
Optimise memory for rest cluster health calls with in-line shard aggr…
SwethaGuptha bf7b772
Mute RemoteMigration flaky test (#15795)
ltaragi 3f627a3
Bump org.apache.commons:commons-lang3 from 3.16.0 to 3.17.0 in /plugi…
dependabot[bot] 8a2cfb5
Change version to 2.17.0 for shallow snapshot V2 restore changes (#15…
sachinpkale 7902f5b
Downgrade version check for ser/de of applyLevelAtTransportLayer flag…
SwethaGuptha f0c689b
Update protobuf from 3.22.3 to 3.25.4 (#15684)
cwperks e30ecf9
Add 2.17 release notes (#15762) (#15768) (#15776)
reta 3ff2df2
Bump org.apache.logging.log4j:log4j-core from 2.23.1 to 2.24.0 in /bu…
dependabot[bot] a3d62b5
Bump peter-evans/create-pull-request from 6 to 7 (#15863)
dependabot[bot] 7d90d62
Remove awaits fix since tests are now passing (#15727)
harshavamsi aab2426
Bump com.nimbusds:oauth2-oidc-sdk from 11.9.1 to 11.19.1 in /plugins/…
dependabot[bot] b784b30
Move changelog entries to release notes which are backported to 2.17 …
shiv0408 9476a05
Update to Gradle 8.10.1 (#15867)
reta 74501ff
[BUG] Bug fix for checksum validation for mapping metadata (#15885)
himshikha 39d69c9
fix escaped wildcard query on wildcard field (#15737)
HUSTERGS 81bfa2e
Add more wait time to assertBusy to fix RemoteFsTimestampAwareTranslo…
sachinpkale 0ba4f16
Fixing MacOS 13 assemble workflows (once again) (#15898)
reta 9f96ea8
updating release-notes for 2.17 (#15884)
rajiv-kv d79da4d
Add cancellation framework changes in wlm (#15651)
kaushalmahi12 02619d7
Fixing the CHANGELOG.md by removing change published in 2.17 (#15903)
jainankitk 2961a6f
using remote cluster-state as fallback (#15424)
rajiv-kv 57262b0
Add restriction to have a single repository with shallow snapshot v2 …
sachinpkale 530abce
Removing task Id from map using remove() (#15918)
sgup432 656e733
Add the capability to override indices.breaker.total.use_real_memory …
navneet1v c41f2ba
Fix flaky org.opensearch.rest.ReactorNetty4StreamingStressIT.testClos…
reta 0fa8cd8
Update TESTING.md 'Building with extra plugins' documentation (#15893)
finnegancarroll 9b1540d
Fix case insensitive query on wildcard field (#15882)
HUSTERGS 945520c
Remove TooManyShardsInSnapshotsStatusException (#15877)
ltaragi 9cc36fe
Revert "Mute failing snapshot status tests (#15652)" (#15876)
ltaragi 3b4a593
Bump com.gradle.develocity from 3.18 to 3.18.1 (#15947)
dependabot[bot] fb26fcd
Bump ch.qos.logback:logback-core from 1.5.6 to 1.5.8 in /test/fixture…
dependabot[bot] e655c5b
remote publication checksum stats (#15957)
himshikha b2624b1
Add validation for the search backpressure cancellation settings (#15…
gaobinlong 8d7735b
Fix flaky terminaton conditions for org.opensearch.rest.ReactorNetty4…
reta e7d62b4
Implement WithFieldName interface in ValuesSourceAggregationBuilder &…
dzane17 46d1197
Bump com.microsoft.azure:msal4j from 1.17.0 to 1.17.1 in /plugins/rep…
dependabot[bot] 19aa90a
Update version in README to 2.18.0 (#15968)
cwperks 3c39ea9
[AUTO] [main] Add bwc version 2.17.1. (#15966)
opensearch-trigger-bot[bot] c2e3426
Refactor branch deletion for backports (#15983)
gaiksaya 91aad15
star tree file formats refactoring and fixing offset bug (#15975)
bharath-techie 4250eee
Fix infinite loop in nested agg (#15931)
kkewwei 5b04daf
Explicitly set include discovery nodes flag in reloadSecureSetting re…
SwethaGuptha 1f0992b
Update version check in yaml test file for bitmap filtering (#15993)
gaobinlong 9f73e13
Fix deleting backport branches workflow (#16003)
gaiksaya 0777074
Remove identity-related feature flagged code from the RestController …
cwperks 82075e2
Update version check in yml test file (#15999)
reta 39e8ca1
Update big5 workload config to use the ordered documents snapshot (#1…
rishabh6788 6511476
Add successfulSearchShardIndices in searchRequestContext before onReq…
dzane17 2d66f5a
add concurrency check to gradle-check workflow (#16007)
rishabh6788 2b5b9b5
Add support for async deletion in S3BlobContainer (#15621)
ashking94 0760cc3
Update protobuf from 3.25.4 to 3.25.5 (#16011)
cwperks 6646d37
Add more yaml rest tests for search backpressure settings (#16012)
gaobinlong ea63451
Avoid infinite loop in flat_object parsing (#15985)
msfroh 9aa3a51
Add disallow settings update during repository in use ITs (#16001)
ashking94 40ff7aa
Fixing flaky test testRemoteIndexPathFileExistsAfterMigration (#15977)
astute-decipher ca4f903
Bump actions/github-script from 5 to 7 (#16039)
dependabot[bot] adb0c85
Fix search_as_you_type not supporting multi-fields (#15988)
gaobinlong f168a52
Fix flaky test in RemoteStoreMigrationSettingsUpdateIT (#16048)
ashking94 00c5ba2
Bump dnsjava:dnsjava from 3.6.1 to 3.6.2 in /test/fixtures/hdfs-fixtu…
dependabot[bot] f73b6b9
Update version check in yaml test file for the bug fix of avoid infin…
gaobinlong 01142d0
Add support for docker compose v2 in TestFixturesPlugin (#16049)
cwperks 110bcce
Change the version to 2.18 as term-check fallback is merged to 2.x (#…
rajiv-kv d93f7b7
Retry remote state download while bootstrap (#15950)
soosinha 69a2c22
Optimize remote store GC flow with pinned timestamps (#15943)
sachinpkale b872ad1
Modify flaky test (#15854)
shiv0408 e9dd632
Fix issue of red index on close for remote enabled clusters (#15990)
ashking94 ec731e4
Fix segment count for optimized agg rest test (#16067)
finnegancarroll c182a90
Added support for msearch API to pass search pipeline name (#15923)
owaiskazi19 3fad50b
Update 390_search_as_you_type.yml (#16065)
reta b06dd95
Allow RemotePublication configured nodes to join remote cluster in mi…
rajiv-kv b2f6d54
Ignore google-cloud-storage and google-api-client major version upgra…
cwperks 77a5b25
Bump com.nimbusds:nimbus-jose-jwt from 9.40 to 9.41.1 in /plugins/rep…
dependabot[bot] ae918a9
Updates version to fix BWC for SearchSourceBuilder (#16086)
owaiskazi19 291343f
Shallow snapshot v2 - create snapshot validations in a cluster state …
gbbafna 3ffa32a
Bump org.roaringbitmap:RoaringBitmap from 1.2.1 to 1.3.0 in /server (…
dependabot[bot] 5828620
Bump com.nimbusds:nimbus-jose-jwt in /test/fixtures/hdfs-fixture (#16…
dependabot[bot] 0286102
Registering disable user-agent setting with OpenSearch (#16052)
saratvemulapalli 2f82da5
Bump com.maxmind.geoip2:geoip2 from 4.2.0 to 4.2.1 in /modules/ingest…
dependabot[bot] a75b0fc
Fix for race condition in node-join/node-left loop (#15521)
rahulkarajgikar 261e6a9
Update Gradle to 8.10.2 (#16107)
reta 14c1e70
Fix testHAProxyModeConnectionWorks is flaky (#16087)
gaobinlong d8a9c83
Implementing pagination for _cat/indices API (#14718)
gargharsh3134 441c433
Bugfix in RemoteFsTimestampAwareTranslog.trimUnreferencedReaders (#16…
sachinpkale 53186b5
Correct the version post backport to 2.18 instead of current (#16127)
gbbafna e996f4c
Add success and failure count OTel metrics for async shard fetch (#15…
rahulkarajgikar 5046d84
Fix version check in yml test file for double range profiler shows fi…
gaobinlong c45eee0
Bump com.maxmind.db:maxmind-db from 3.1.0 to 3.1.1 in /modules/ingest…
dependabot[bot] 4784e98
Add default implementation to new finalizeSnapshot() in Repository (#…
sachinpkale b6ce541
Bump org.apache.logging.log4j:log4j-core from 2.24.0 to 2.24.1 in /bu…
dependabot[bot] 904ab84
Add 2.17.1 release notes (#16104) (#16105) (#16132)
reta 3abdb06
Add assertBusy to failing snapshot tests (#16146)
ltaragi df36ee3
Optimize checksum creation for remote cluster state (#16046)
himshikha 20612d0
Bump com.azure:azure-core-http-netty from 1.15.3 to 1.15.4 in /plugin…
dependabot[bot] 148928d
[SnapshotV2] Add timestamp of last successful fetch of pinned timesta…
ltaragi da6cd88
Bump org.jline:jline from 3.26.3 to 3.27.0 in /test/fixtures/hdfs-fix…
dependabot[bot] 7841a47
Remove Identity FeatureFlag (#16024)
cwperks 8b36dc5
Change default retry mechanism of s3 client to Standard Mode (#15978)
Arpit-Bandejiya a83d57b
Ensure RestHandler.Wrapper delegates all implementations to the wrapp…
cwperks 5bdb712
[BUG] Streaming bulk request hangs (#16158)
reta a3bfe5b
Fix client-rest-high-level tests for ppc64le (#16089)
prachi-gaonkar 7b2ce5c
[AUTO] [main] Add bwc version 2.17.2. (#16166)
opensearch-trigger-bot[bot] bf3eb08
Change version checks from CURRENT to 2.18 (#16174)
ltaragi 9f367f9
Add changes to block calls in cat shards, indices and segments based …
sumitasr 2c62612
Separate Remote State and Publication enabled and configured methods …
shiv0408 ed2a958
[Snapshot V2] Remove orphan timestamps post create snapshot completio…
gbbafna f1dab8a
Bump Netty to 4.1.114.Final (#16182)
reta 2d8d507
Implement phone number analyzer (#15915)
rursprung c85ebbc
Fix japicmp configuration by treating abstract-to-default method chan…
reta 2ee4675
Add more unit tests for RemoteStoreUtils and RemoteFsTimestampAwareTr…
sachinpkale d43e779
Run queued operations post v2 operations completion (#16179)
gbbafna e074117
Fix warnings from SLF4J on startup when repository-s3 is installed (#…
cwperks d76c9f6
Fix unknown parameter source_remote_translog_repository bug (#16192)
sachinpkale 35c62b5
Mute snapshot v2 flaky tests (#16193)
gbbafna c6b1db5
Implementing pagination for _cat/shards (#14641)
gargharsh3134 8c2fd36
Update Apache Lucene to 9.12.0 (#15333)
reta 6ab90bc
Latency improvements to Multi Term Aggregations (#14993)
expani bf27c9a
Add wlm resiliency orchestrator (query group service) (#15925)
kaushalmahi12 67d56fc
[Tiered Caching] Segmented cache changes (#16047)
sgup432 9d7d300
[Star tree] Add date field rounding support in star tree (#15249)
bharath-techie cc0f606
[Star tree] Refactoring builder tests (#16036)
bharath-techie 6a7422e
Change successfulSearchShardIndices to Set<Index> (#16110)
dzane17 5201925
Add more concurrent Snapshot V2 Integ Tests (#16207)
gbbafna 5bf938a
Bump com.azure:azure-json from 1.1.0 to 1.3.0 in /plugins/repository-…
dependabot[bot] 725d942
Close RemoteStorePinnedTimestampService on Node.close() (#16228)
sachinpkale 92fb482
Add TLSv1.3 in jdk.tls.client.protocols systemProp in gradle.properti…
cwperks 10edf5d
Attempt to delete backport branches only for OpenSearch repo (#16240)
gaiksaya 17b5ad3
Fix Cache backward compatibility breaking change (#16238)
sgup432 9ca57e7
[Star tree] Moving compositeCodec to composite912Codec and dropping c…
bharath-techie 221fe8a
Bump com.google.api-client:google-api-client from 2.2.0 to 2.7.0 in /…
dependabot[bot] 6197361
Update Apache Lucene version for 2.18.0 (#16252)
reta 909a90f
Bump com.squareup.okio:okio from 3.9.0 to 3.9.1 in /test/fixtures/hdf…
dependabot[bot] 481264c
Bump io.grpc:grpc-api from 1.57.2 to 1.68.0 in /plugins/discovery-gce…
dependabot[bot] b62b0dd
Remove redundant force merge - histo rest tests (#16144)
finnegancarroll 45b3fcc
The protobuf-java leaks through client library dependencies (#16254)
reta cfacf49
Fix Flaky Test org.opensearch.gateway.RecoveryFromGatewayIT.testShard…
kkewwei 6dc6032
Revert remote publication method renaming in DiscoveryNode (#16250)
soosinha d60b0cd
BugFix: call listener.onFailure on failure to pin the timestamp (#16248)
sachinpkale b27f370
[Workload Management] QueryGroup Stats API Logic (#15777)
ruai0511 c88eb0b
Add Integration Tests for Workload Management CRUD APIs (#15955)
ruai0511 57fb786
Reconfigure remote state thread pool count (#16245)
soosinha 4e24581
Add snapshot_path prefix to snapshot shards path file on S3 (#16267)
ashking94 683e43f
Support JDK-23 (build time and runtime) (#16257)
reta b57b3de
Making wlm stats output easier to understand (#16278)
kaushalmahi12 7815472
Change remote store restore cluster state priority to URGENT (#16281)
sachinpkale 026d27d
Update setting API honors cluster's replica setting as default #14810…
chishui c465752
Remove ApproximateIndexOrDocValuesQuery (#16273)
msfroh fa452d7
Fix IndicesRequestCacheIt flaky tests (#16276)
sgup432 43505c9
Skip unnecessary string format in RemoteStoreMigrationAllocationDecid…
imRishN 9d4843c
Optimise clone operation for incremental full cluster snapshots (#16296)
ashking94 784e3fb
Fix multi-search with template doesn't return status code (#16265)
gaobinlong 4e7f706
[Snapshot V2] Move timestamp pinning before cluster state update (#16…
gbbafna 018a917
Bump ch.qos.logback:logback-core from 1.5.8 to 1.5.10 in /test/fixtur…
dependabot[bot] 730e747
Bump me.champeau.gradle.japicmp from 0.4.3 to 0.4.4 in /server (#16309)
dependabot[bot] 07cf220
Bump com.google.oauth-client:google-oauth-client from 1.35.0 to 1.36.…
dependabot[bot] 33913d2
Bump lycheeverse/lychee-action from 1.10.0 to 2.0.2 (#16310)
dependabot[bot] 60c0c43
Bump com.azure:azure-core-http-netty from 1.15.4 to 1.15.5 in /plugin…
dependabot[bot] f06a209
Bump com.google.code.gson:gson from 2.10.1 to 2.11.0 in /plugins/repo…
dependabot[bot] 817dbc8
Enable coordinator search.request_stats_enabled by default (#16290)
dzane17 78341f4
Flat object field should delegate to keyword field for most query typ…
kkewwei c8e97e9
Add new benchmark config for query approximation (#16323)
msfroh 1ddf351
Update last seen cluster state in commit phase (#16215)
soosinha 32497c3
Add support to dynamically resize threadpools size (#16236)
gbbafna 0bbd19d
Fix deletion permits flow in RemoteFsTimestampAwareTranslog (#16282)
sachinpkale 3e37dfd
Fix wrong default value when setting index.number_of_routing_shards t…
gaobinlong 37222b1
JDK-23: Mitigation for https://bugs.openjdk.org/browse/JDK-8341127 is…
reta 971961e
Bugfix in snapshot V2 restore flow (#16332)
sachinpkale ccd3f50
fix cluster not able to spin up issue when disk usage exceeds thresho…
zane-neo d88c754
[Snapshot V2] Use metadata from source snapshot while cloning snapsho…
gbbafna 11f8ef1
[Streaming Indexing] Fix intermittent 'The bulk request must be termi…
reta 8cff5f1
Fixed inefficient Stream API call chains ending with count() (#15386)
dk2k 675faf3
Update 10_basic.yml (#16349)
reta 2e59425
Make Remote Publication a dynamic setting (#15937)
shiv0408 2d5083b
[Star tree] Performance optimizations during flush flow (#16037)
bharath-techie 2b893bc
Skip media type parsing for known string values (#16358)
andrross ce74105
Fixed assignment to catch block parameter (#15384)
dk2k File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are increasing time complexity by doing this change for sure. Is there a specific reason for doing this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sandeshkr419 the hash of
operations
here is the array object's hash, but does not hash the contents. You could have a case of two different arrays containing the same elements, which would produce a different hashCode here but match the.equals()
check which usesArrays.equals()
. This is a good change.