Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading gson to 2.8.9 #1541

Merged
merged 1 commit into from
Nov 15, 2021
Merged

Conversation

VachaShah
Copy link
Collaborator

Signed-off-by: Vacha vachshah@amazon.com

Description

Upgrading gson to latest 2.8.9 in direct dependency and via hadoop-common.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Vacha <vachshah@amazon.com>
@VachaShah VachaShah requested a review from a team as a code owner November 12, 2021 22:31
@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success d7b78ba

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success d7b78ba

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure d7b78ba
Log 1066

Reports 1066

@VachaShah
Copy link
Collaborator Author

❌   Gradle Check failure d7b78ba Log 1066

Reports 1066

Tests with failures:
 - org.opensearch.discovery.StableMasterDisruptionIT.testStaleMasterNotHijackingMajority

2632 tests completed, 1 failed, 4 skipped
1> [2021-11-12T16:43:27,115][WARN ][o.o.c.NodeConnectionsService] [node_t2] failed to connect to {node_t1}{sPuJWTDSQC-Dglo7tjZfog}{6VrTsrXIRcaOHwn8m9dFdw}{127.0.0.1}{127.0.0.1:43109}{dimr}{shard_indexing_pressure_enabled=true} (tried [1] times)
  1> org.opensearch.transport.ConnectTransportException: [node_t1][127.0.0.1:43109] connect_exception
  1> 	at org.opensearch.transport.TcpTransport$ChannelsConnectedListener.onFailure(TcpTransport.java:1064) ~[main/:?]
  1> 	at org.opensearch.action.ActionListener.lambda$toBiConsumer$2(ActionListener.java:213) ~[main/:?]
  1> 	at org.opensearch.common.concurrent.CompletableContext.lambda$addListener$0(CompletableContext.java:55) ~[opensearch-core-2.0.0-SNAPSHOT.jar:2.0.0-SNAPSHOT]
  1> 	at java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:863) ~[?:?]
  1> 	at java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:841) ~[?:?]
  1> 	at java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:510) ~[?:?]
  1> 	at java.util.concurrent.CompletableFuture.completeExceptionally(CompletableFuture.java:2162) ~[?:?]
  1> 	at org.opensearch.common.concurrent.CompletableContext.completeExceptionally(CompletableContext.java:70) ~[opensearch-core-2.0.0-SNAPSHOT.jar:2.0.0-SNAPSHOT]
  1> 	at org.opensearch.nio.SocketChannelContext.connect(SocketChannelContext.java:160) ~[opensearch-nio-2.0.0-SNAPSHOT.jar:2.0.0-SNAPSHOT]
  1> 	at org.opensearch.nio.EventHandler.handleConnect(EventHandler.java:130) ~[opensearch-nio-2.0.0-SNAPSHOT.jar:2.0.0-SNAPSHOT]
  1> 	at org.opensearch.transport.nio.TestEventHandler.handleConnect(TestEventHandler.java:139) ~[framework-2.0.0-SNAPSHOT.jar:2.0.0-SNAPSHOT]
  1> 	at org.opensearch.nio.NioSelector.attemptConnect(NioSelector.java:446) ~[opensearch-nio-2.0.0-SNAPSHOT.jar:2.0.0-SNAPSHOT]
  1> 	at org.opensearch.nio.NioSelector.registerChannel(NioSelector.java:469) ~[opensearch-nio-2.0.0-SNAPSHOT.jar:2.0.0-SNAPSHOT]
  1> 	at org.opensearch.nio.NioSelector.setUpNewChannels(NioSelector.java:458) ~[opensearch-nio-2.0.0-SNAPSHOT.jar:2.0.0-SNAPSHOT]
  1> 	at org.opensearch.nio.NioSelector.preSelect(NioSelector.java:279) ~[opensearch-nio-2.0.0-SNAPSHOT.jar:2.0.0-SNAPSHOT]
  1> 	at org.opensearch.nio.NioSelector.singleLoop(NioSelector.java:172) ~[opensearch-nio-2.0.0-SNAPSHOT.jar:2.0.0-SNAPSHOT]
  1> 	at org.opensearch.nio.NioSelector.runLoop(NioSelector.java:148) ~[opensearch-nio-2.0.0-SNAPSHOT.jar:2.0.0-SNAPSHOT]
  1> 	at java.lang.Thread.run(Thread.java:833) [?:?]
  1> Caused by: java.net.ConnectException: Connection refused
  1> 	at sun.nio.ch.Net.pollConnect(Native Method) ~[?:?]
  1> 	at sun.nio.ch.Net.pollConnectNow(Net.java:672) ~[?:?]
  1> 	at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:946) ~[?:?]
  1> 	at org.opensearch.nio.SocketChannelContext.connect(SocketChannelContext.java:157) ~[opensearch-nio-2.0.0-SNAPSHOT.jar:2.0.0-SNAPSHOT]
  1> 	... 9 more

@VachaShah
Copy link
Collaborator Author

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure d7b78ba
Log 1067

Reports 1067

@VachaShah
Copy link
Collaborator Author

❌   Gradle Check failure d7b78ba Log 1067

Reports 1067

> Task :test:fixtures:s3-fixture:composeUp

ERROR: for 56aa93ed60e3e11b06e2067e06b0dd8c_s3-fixture__s3-fixture-with-ec2_1  UnixHTTPConnectionPool(host='localhost', port=None): Read timed out. (read timeout=60)
Creating 56aa93ed60e3e11b06e2067e06b0dd8c_s3-fixture__s3-fixture-repositories-metering_1 ... done
Creating 56aa93ed60e3e11b06e2067e06b0dd8c_s3-fixture__s3-fixture-with-ecs_1              ... done
Creating 56aa93ed60e3e11b06e2067e06b0dd8c_s3-fixture__s3-fixture-with-session-token_1    ... done
Creating 56aa93ed60e3e11b06e2067e06b0dd8c_s3-fixture__s3-fixture-other_1                 ... done
Creating 56aa93ed60e3e11b06e2067e06b0dd8c_s3-fixture__s3-fixture_1                       ... done

ERROR: for s3-fixture-with-ec2  UnixHTTPConnectionPool(host='localhost', port=None): Read timed out. (read timeout=60)
An HTTP request took too long to complete. Retry with --verbose to obtain debug information.
If you encounter this issue regularly because of slow network conditions, consider setting COMPOSE_HTTP_TIMEOUT to a higher value (current value: 60).
Stopping 56aa93ed60e3e11b06e2067e06b0dd8c_s3-fixture__s3-fixture-repositories-metering_1 ... 
Stopping 56aa93ed60e3e11b06e2067e06b0dd8c_s3-fixture__s3-fixture-with-ecs_1              ... 
Stopping 56aa93ed60e3e11b06e2067e06b0dd8c_s3-fixture__s3-fixture_1                       ... 
Stopping 56aa93ed60e3e11b06e2067e06b0dd8c_s3-fixture__s3-fixture-other_1                 ... 
Stopping 56aa93ed60e3e11b06e2067e06b0dd8c_s3-fixture__s3-fixture-with-session-token_1    ... 

@VachaShah
Copy link
Collaborator Author

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure d7b78ba
Log 1068

Reports 1068

@VachaShah
Copy link
Collaborator Author

❌   Gradle Check failure d7b78ba Log 1068

Reports 1068

REPRODUCE WITH: ./gradlew ':server:test' --tests "org.opensearch.monitor.fs.FsHealthServiceTests.testFailsHealthOnHungIOBeyondHealthyTimeout" -Dtests.seed=20C97377870AC21B -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=nb -Dtests.timezone=Australia/Sydney -Druntime.java=17

org.opensearch.monitor.fs.FsHealthServiceTests > testFailsHealthOnHungIOBeyondHealthyTimeout FAILED
    java.lang.AssertionError
        at __randomizedtesting.SeedInfo.seed([20C97377870AC21B:A2BD2D7EF3F6B453]:0)
        at org.junit.Assert.fail(Assert.java:86)
        at org.junit.Assert.assertTrue(Assert.java:41)
        at org.junit.Assert.assertTrue(Assert.java:52)
        at org.opensearch.monitor.fs.FsHealthServiceTests.testFailsHealthOnHungIOBeyondHealthyTimeout(FsHealthServiceTests.java:239)

@tlfeng
Copy link
Collaborator

tlfeng commented Nov 13, 2021

The test failure from ./gradlew ':server:test' --tests "org.opensearch.monitor.fs.FsHealthServiceTests.testFailsHealthOnHungIOBeyondHealthyTimeout" has been reported before, in issue #1307 and #1450.

@VachaShah
Copy link
Collaborator Author

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success d7b78ba
Log 1084

Reports 1084

@dblock dblock merged commit c6dd484 into opensearch-project:main Nov 15, 2021
VachaShah added a commit to VachaShah/OpenSearch that referenced this pull request Nov 15, 2021
Signed-off-by: Vacha <vachshah@amazon.com>
@VachaShah VachaShah deleted the gson-upgrade branch November 15, 2021 21:23
CEHENKLE pushed a commit that referenced this pull request Nov 16, 2021
Signed-off-by: Vacha <vachshah@amazon.com>
VachaShah added a commit to VachaShah/OpenSearch that referenced this pull request Nov 19, 2021
Signed-off-by: Vacha <vachshah@amazon.com>
saratvemulapalli pushed a commit that referenced this pull request Nov 19, 2021
Signed-off-by: Vacha <vachshah@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants