Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to skip pinned timestamp in remote translog garbage collector #15416

Merged
merged 14 commits into from
Sep 2, 2024

Conversation

sachinpkale
Copy link
Member

@sachinpkale sachinpkale commented Aug 26, 2024

Description

  • As part of shallow snapshot optimisations, we are introducing timestamp based implicit locking support. This feature will be called Timestamp Pinning in remote backed storage. When a timestamp is pinned, remote store garbage collectors will skip deleting data corresponding to the timestamp.
  • Changes to segment store garbage collection are made as part of PR: Add support to skip pinned timestamp in remote segment garbage collector #15017
  • In this PR, we are making following changes to translog garbage collection:
    • Fetch metadata files in reverse-chronological order
    • Filter out metadata files that match with pinned timestamp and metadata files that are created post successful fetch of pinned timestamp.
    • From the remaining metadata files, read min and max generation and filter out generations by pinned timestamp metadata files.

Related Issues

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for 56d7626: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@sachinpkale sachinpkale force-pushed the translog-gc-timestamp branch from 56d7626 to 82091a2 Compare August 27, 2024 03:14
Copy link
Contributor

❌ Gradle check result for 82091a2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 1a280db: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@sachinpkale sachinpkale force-pushed the translog-gc-timestamp branch from 1a280db to d9a6dc6 Compare August 28, 2024 03:25
Signed-off-by: Sachin Kale <kalsac@amazon.com>
Copy link
Contributor

github-actions bot commented Sep 1, 2024

❌ Gradle check result for a69a975: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Sachin Kale <kalsac@amazon.com>
Copy link
Contributor

github-actions bot commented Sep 1, 2024

❌ Gradle check result for 770a791: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 1, 2024

❌ Gradle check result for 770a791: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 1, 2024

❕ Gradle check result for 770a791: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.smoketest.SmokeTestMultiNodeClientYamlTestSuiteIT.test {yaml=search.aggregation/360_date_histogram/Date histogram aggregation w/ shared field range test}
      1 org.opensearch.action.admin.cluster.node.tasks.ResourceAwareTasksTests.testTaskResourceTrackingDuringTaskCancellation

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@gbbafna gbbafna merged commit ef47252 into opensearch-project:main Sep 2, 2024
34 checks passed
@sachinpkale sachinpkale added the backport 2.x Backport to 2.x branch label Sep 2, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 2, 2024
…ctor (#15416)

Signed-off-by: Sachin Kale <kalsac@amazon.com>
(cherry picked from commit ef47252)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sachinpkale pushed a commit that referenced this pull request Sep 2, 2024
…ctor (#15416) (#15567)

(cherry picked from commit ef47252)

Signed-off-by: Sachin Kale <kalsac@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants