-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add query group level rejection logic #15428
Add query group level rejection logic #15428
Conversation
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
❌ Gradle check result for b583b61: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
❌ Gradle check result for 5811101: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for c94f41e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for d51b251: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
❕ Gradle check result for e29269e: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15428 +/- ##
============================================
+ Coverage 71.92% 71.98% +0.05%
- Complexity 63483 63570 +87
============================================
Files 5244 5246 +2
Lines 296911 296930 +19
Branches 42879 42880 +1
============================================
+ Hits 213557 213747 +190
+ Misses 65799 65743 -56
+ Partials 17555 17440 -115 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
❌ Gradle check result for 5629506: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15428-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c11d27575b87bd41f9e6512f48591ec0443eaf16
# Push it to GitHub
git push --set-upstream origin backport/backport-15428-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
* add rejection listener Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add rejection listener unit test Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add rejection logic for shard level requests Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add changelog entry Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * apply spotless check Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * remove unused files and fix precommit Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * refactor code Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add package info file Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * remove unused method from QueryGroupService stub Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> --------- Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
* add rejection listener * add rejection listener unit test * add rejection logic for shard level requests * add changelog entry * apply spotless check * remove unused files and fix precommit * refactor code * add package info file * remove unused method from QueryGroupService stub --------- Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
* add rejection listener Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add rejection listener unit test Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add rejection logic for shard level requests Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add changelog entry Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * apply spotless check Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * remove unused files and fix precommit Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * refactor code Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add package info file Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * remove unused method from QueryGroupService stub Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> --------- Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
* add rejection listener Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add rejection listener unit test Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add rejection logic for shard level requests Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add changelog entry Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * apply spotless check Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * remove unused files and fix precommit Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * refactor code Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add package info file Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * remove unused method from QueryGroupService stub Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> --------- Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
* add rejection listener Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add rejection listener unit test Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add rejection logic for shard level requests Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add changelog entry Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * apply spotless check Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * remove unused files and fix precommit Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * refactor code Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add package info file Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * remove unused method from QueryGroupService stub Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> --------- Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
* add rejection listener Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add rejection listener unit test Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add rejection logic for shard level requests Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add changelog entry Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * apply spotless check Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * remove unused files and fix precommit Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * refactor code Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add package info file Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * remove unused method from QueryGroupService stub Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> --------- Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
Description
With this change, we will be able to reject the requests for contended query groups.
Note
QueryGroupService
is a stub here and will be replaced by the actual implementation in next couple of daysQueryGroupService
are intentionally left out to avoid the duplicate efforts.Related Issues
RFC: #12342
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.