Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore snapshot changes for shallow snapshot V2 #15462

Merged
merged 6 commits into from
Sep 3, 2024
Merged

Restore snapshot changes for shallow snapshot V2 #15462

merged 6 commits into from
Sep 3, 2024

Conversation

sachinpkale
Copy link
Member

@sachinpkale sachinpkale commented Aug 28, 2024 •
edited
Loading

Description

  • As part of shallow snapshot V2 optimizations, we introduced timestamp pinning functionality for remote store data.
  • This PR contains changes related to restore of shallow snapshot V2.
  • Restoring shallow snapshot V2 involves following changes:
    • Identify if snapshot is shallow snapshot V2 (based on pinned timestamp field in snapshot info)
    • Restore segments corresponding to the pinned timestamp in snapshot
    • Restore and replay translog corresponding to the pinned timestamp in snapshot

Related Issues

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for c9d6deb: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for e76753f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@sachinpkale sachinpkale force-pushed the v2-snapshot-restore branch 2 times, most recently from a5dd779 to 56cca2a Compare August 28, 2024 12:03
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for a5dd779: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 56cca2a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 58666c2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@sachinpkale sachinpkale force-pushed the v2-snapshot-restore branch 2 times, most recently from b16d343 to df1b7ac Compare August 30, 2024 04:16
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for b16d343: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for df1b7ac: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 570d138: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 1, 2024

❌ Gradle check result for ea6c2d3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 1, 2024

❌ Gradle check result for 8d49a6f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 1, 2024

❌ Gradle check result for 2fc3b51: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 1, 2024

❌ Gradle check result for 4a68ff5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@sachinpkale sachinpkale force-pushed the v2-snapshot-restore branch 2 times, most recently from a2fa7e6 to 58cd123 Compare September 2, 2024 04:04
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 2, 2024

❌ Gradle check result for a2fa7e6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@sachinpkale sachinpkale changed the title Restore snapshot changes for V2 Restore snapshot changes for shallow snapshot V2 Sep 2, 2024
@sachinpkale sachinpkale marked this pull request as ready for review September 2, 2024 04:12
sachinpkale added a commit to sachinpkale/OpenSearch that referenced this pull request Sep 6, 2024
@sachinpkale @gbbafna
Restore snapshot changes for shallow snapshot V2 (opensearch-project#…
0c7dbb9 
…15462)

---------

Signed-off-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Gaurav Bafna <gbbafna@amazon.com>
sachinpkale added a commit to sachinpkale/OpenSearch that referenced this pull request Sep 6, 2024
@sachinpkale @gbbafna
Restore snapshot changes for shallow snapshot V2 (opensearch-project#…
d524515 
…15462)

---------

Signed-off-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Gaurav Bafna <gbbafna@amazon.com>
sachinpkale added a commit to sachinpkale/OpenSearch that referenced this pull request Sep 6, 2024
@sachinpkale @gbbafna
Restore snapshot changes for shallow snapshot V2 (opensearch-project#…
8fc0d8a 
…15462)

---------

Signed-off-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Sachin Kale <kalsac@amazon.com>
sachinpkale added a commit to sachinpkale/OpenSearch that referenced this pull request Sep 6, 2024
@sachinpkale @gbbafna
Restore snapshot changes for shallow snapshot V2 (opensearch-project#…
1c12a6f 
…15462)

---------

Signed-off-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Sachin Kale <kalsac@amazon.com>
sachinpkale added a commit that referenced this pull request Sep 6, 2024
@sachinpkale @mch2
@ltaragi @gbbafna @anshu1106
Flaky tests fix in 2.x branch (#15805)
a24c858 
* Mute test testRemoteStoreCleanupForDeletedIndexForSnapshotV2 (#15695)

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>

* Mute flaky test RemoteFsTimestampAwareTranslogTests.testSimpleOperationsUpload (#15732)

Signed-off-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Sachin Kale <kalsac@amazon.com>

* Mute failing snapshot status tests (#15652)

Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
Signed-off-by: Sachin Kale <kalsac@amazon.com>
Signed-off-by: Lakshya Taragi <157457166+ltaragi@users.noreply.github.com>

* Restore snapshot changes for shallow snapshot V2 (#15462)

---------

Signed-off-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Sachin Kale <kalsac@amazon.com>

* version change to V_2.17.0 for node min version check (#15644)

Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Co-authored-by: Anshu Agarwal <anshukag@amazon.com>
Signed-off-by: Sachin Kale <kalsac@amazon.com>

---------

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
Signed-off-by: Sachin Kale <kalsac@amazon.com>
Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
Signed-off-by: Lakshya Taragi <157457166+ltaragi@users.noreply.github.com>
Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Co-authored-by: Marc Handalian <marc.handalian@gmail.com>
Co-authored-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Lakshya Taragi <157457166+ltaragi@users.noreply.github.com>
Co-authored-by: Gaurav Bafna <gbbafna@amazon.com>
Co-authored-by: Anshu Agarwal <anshuagarwal11@gmail.com>
Co-authored-by: Anshu Agarwal <anshukag@amazon.com>
This was referenced Sep 6, 2024
Open
Open
Open
Open
Closed
Open
Open
Closed
Open
Open
Open
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
@sachinpkale @gbbafna @akolarkunnu
Restore snapshot changes for shallow snapshot V2 (opensearch-project#…
776b20e 
…15462)

---------

Signed-off-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Gaurav Bafna <gbbafna@amazon.com>
This was referenced Sep 11, 2024
Open
Open
Open
Open
Open
Open
Open
Open
@prudhvigodithi prudhvigodithi mentioned this pull request Oct 16, 2024
Open
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
@sachinpkale @gbbafna @dk2k
Restore snapshot changes for shallow snapshot V2 (opensearch-project#…
daaa9e9 
…15462)

---------

Signed-off-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Gaurav Bafna <gbbafna@amazon.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
@sachinpkale @gbbafna @dk2k
Restore snapshot changes for shallow snapshot V2 (opensearch-project#…
41e7343 
…15462)

---------

Signed-off-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Gaurav Bafna <gbbafna@amazon.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
@sachinpkale @gbbafna @dk2k
Restore snapshot changes for shallow snapshot V2 (opensearch-project#…
721289b 
…15462)

---------

Signed-off-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Gaurav Bafna <gbbafna@amazon.com>
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Nov 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbbafna gbbafna gbbafna approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch backport-failed skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sachinpkale @gbbafna