Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing backward incompatibility check from #15473 #15486

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

jainankitk
Copy link
Collaborator

Description

Fixes the backward incompatibility introduced in #15473

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • [ ] Functionality includes testing.
  • [ ] API changes companion pull request created, if applicable.
  • [ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Ankit Jain <akjain@amazon.com>
Signed-off-by: Ankit Jain <akjain@amazon.com>
Signed-off-by: Ankit Jain <akjain@amazon.com>
Copy link
Contributor

❌ Gradle check result for 601e350: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for b22e94b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for eff0f25: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@jainankitk
Copy link
Collaborator Author

Gradle failure seems unrelated. Related to #15117

[org.opensearch.cluster.service.MasterServiceTests.testClusterStateUpdateLoggingWithDebugEnabled]

Copy link
Contributor

✅ Gradle check result for eff0f25: SUCCESS

@reta reta merged commit 461e2b3 into opensearch-project:2.x Aug 29, 2024
33 checks passed
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 71.64%. Comparing base (c63ad5a) to head (eff0f25).
Report is 2 commits behind head on 2.x.

Files with missing lines Patch % Lines
.../main/java/org/opensearch/search/ResourceType.java 0.00% 15 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #15486      +/-   ##
============================================
- Coverage     71.72%   71.64%   -0.08%     
+ Complexity    63609    63585      -24     
============================================
  Files          5216     5217       +1     
  Lines        297554   297569      +15     
  Branches      43311    43312       +1     
============================================
- Hits         213417   213203     -214     
- Misses        66330    66526     +196     
- Partials      17807    17840      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants