Fix RepositoriesServiceIT.testUpdateRepository from #15426 #15559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t#15426 Signed-off-by: Ashish Singh <ssashish@amazon.com>
ashking94
requested review from
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
sachinpkale
approved these changes
Sep 1, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15559 +/- ##
============================================
- Coverage 71.99% 71.95% -0.04%
- Complexity 63700 63734 +34
============================================
Files 5248 5249 +1
Lines 297416 297643 +227
Branches 42984 43011 +27
============================================
+ Hits 214113 214175 +62
- Misses 65776 65897 +121
- Partials 17527 17571 +44 ☔ View full report in Codecov by Sentry. |
ashking94
added a commit
to ashking94/OpenSearch
that referenced
this pull request
Sep 4, 2024
…t#15426 (opensearch-project#15559) Signed-off-by: Ashish Singh <ssashish@amazon.com>
ashking94
added a commit
to ashking94/OpenSearch
that referenced
this pull request
Sep 4, 2024
…t#15426 (opensearch-project#15559) Signed-off-by: Ashish Singh <ssashish@amazon.com>
akolarkunnu
pushed a commit
to akolarkunnu/OpenSearch
that referenced
this pull request
Sep 10, 2024
…t#15426 (opensearch-project#15559) Signed-off-by: Ashish Singh <ssashish@amazon.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 16, 2024
…t#15426 (opensearch-project#15559) Signed-off-by: Ashish Singh <ssashish@amazon.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 17, 2024
…t#15426 (opensearch-project#15559) Signed-off-by: Ashish Singh <ssashish@amazon.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 21, 2024
…t#15426 (opensearch-project#15559) Signed-off-by: Ashish Singh <ssashish@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The RepositoriesServiceIT.testUpdateRepository had become flaky after the PR #15426. Build failure link - https://build.ci.opensearch.org/job/gradle-check/46080/. In the earlier PR, we had made a change to randomise the shard_path_type for all the existing snapshot ITs. This tests check that if the repository has no changes then the instance of repository should remain the same. Due to the randomness introduced earlier, this lead to different instance of repository before the update and after the update. This is now fixed by ensuring that we don't change the repository settings when it is not expected to.
Check List
[ ] API changes companion pull request created, if applicable.[ ] Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.