Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Change pinned timestamp file format stored in remote store #15587

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport cfcfe21 from #15526.

---------

Signed-off-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Sachin Kale <kalsac@amazon.com>
(cherry picked from commit cfcfe21)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

github-actions bot commented Sep 3, 2024

❕ Gradle check result for 4332a4b: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 45 lines in your changes missing coverage. Please review.

Project coverage is 71.72%. Comparing base (834b7c1) to head (4332a4b).
Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
...remotestore/RemoteStorePinnedTimestampService.java 25.00% 43 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #15587      +/-   ##
============================================
- Coverage     71.73%   71.72%   -0.02%     
+ Complexity    63966    63949      -17     
============================================
  Files          5241     5239       -2     
  Lines        299111   299071      -40     
  Branches      43539    43539              
============================================
- Hits         214569   214495      -74     
+ Misses        66626    66606      -20     
- Partials      17916    17970      +54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sachinpkale
Copy link
Member

CodeCov is less because:

  • Most of the changes in this PR contains deleting the files/code.
  • Changes are covered as part of integ tests that CodeCov does not consider.

@sachinpkale sachinpkale merged commit 202eddf into 2.x Sep 3, 2024
59 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant