Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release latch listeners in case of no-op RoutingTableService #15614

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Release latch listeners in case of no-op RoutingTableService #15614

wants to merge 4 commits into from

Conversation

shiv0408
Copy link
Member

@shiv0408 shiv0408 commented Sep 3, 2024

Description

We are currently blocking the latched listeners in case of NoopRemoteRoutingTableService read and write actions. In case of publication is being disabled or enabled by rolling restart. Some nodes will be running on Noop service but will timeout downloading the cluster state.

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@shiv0408
Release latch listeners in case of no-op RoutingTableService
cc815d4 
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
@shiv0408 shiv0408 marked this pull request as ready for review September 3, 2024 14:51
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

❌ Gradle check result for cc815d4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@shiv0408 shiv0408 closed this Sep 5, 2024
@shiv0408 shiv0408 reopened this Sep 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024

❌ Gradle check result for cc815d4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024

❌ Gradle check result for b6fdbcc: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024

✅ Gradle check result for 81682d4: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Sep 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.87%. Comparing base (729e40d) to head (937e34f).
Report is 295 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #15614      +/-   ##
============================================
- Coverage     71.95%   71.87%   -0.09%     
+ Complexity    64192    64159      -33     
============================================
  Files          5270     5271       +1     
  Lines        300052   300170     +118     
  Branches      43368    43380      +12     
============================================
- Hits         215917   215740     -177     
- Misses        66442    66686     +244     
- Partials      17693    17744      +51

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Bukhtawar
Bukhtawar previously approved these changes Sep 5, 2024
View reviewed changes
Bukhtawar
Bukhtawar reviewed Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@Bukhtawar Bukhtawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might need to add some tests

@Bukhtawar Bukhtawar dismissed their stale review September 5, 2024 17:27

Need tests

@shiv0408
Add UT
937e34f 
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024

✅ Gradle check result for 937e34f: SUCCESS

@dblock dblock requested a review from Bukhtawar September 10, 2024 12:16
This was referenced Sep 11, 2024
Open
Open
Open
@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added stalled Issues that have stalled and removed stalled Issues that have stalled labels Oct 11, 2024
@prudhvigodithi prudhvigodithi mentioned this pull request Oct 16, 2024
Open
@shiv0408 shiv0408 requested a review from Bukhtawar October 29, 2024 14:41
@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added stalled Issues that have stalled and removed stalled Issues that have stalled labels Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shiv0408 @Bukhtawar