Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version check for BWC of Discovery Node serialization #15620

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

RS146BIJAY
Copy link
Contributor

Description

Fix version check to 2.17 for BWC of Discovery Node serialization.

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Sep 3, 2024

❕ Gradle check result for e390fba: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.95%. Comparing base (eb1cbb8) to head (ad32317).
Report is 6 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #15620      +/-   ##
============================================
+ Coverage     71.92%   71.95%   +0.02%     
- Complexity    64076    64162      +86     
============================================
  Files          5263     5263              
  Lines        299569   299569              
  Branches      43303    43303              
============================================
+ Hits         215467   215542      +75     
+ Misses        66391    66382       -9     
+ Partials      17711    17645      -66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: RS146BIJAY <rishavsagar4b1@gmail.com>
Copy link
Contributor

github-actions bot commented Sep 3, 2024

❕ Gradle check result for ad32317: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@Bukhtawar Bukhtawar merged commit f7b78d1 into opensearch-project:main Sep 4, 2024
34 checks passed
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants