Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Optimise unassigned shards iteration after allocator timeout & Fix responsibility check for existing shards allocator when timed out #15648

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

imRishN
Copy link
Member

@imRishN imRishN commented Sep 4, 2024

Description

Backport #15176 #15223

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…rch-project#14977)

* Optimise unassigned shards iteration after allocator timeout

Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
…opensearch-project#15223)

* Fix responsibility check for existing shards allocator when timed out

Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@imRishN imRishN changed the title Backport 15223 15176 [Backport 2.x] Optimise unassigned shards iteration after allocator timeout & Fix responsibility check for existing shards allocator when timed out Sep 4, 2024
@imRishN imRishN marked this pull request as ready for review September 4, 2024 07:33
Copy link
Contributor

github-actions bot commented Sep 4, 2024

✅ Gradle check result for 5a34ef8: SUCCESS

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.66%. Comparing base (7fdc07a) to head (5a34ef8).
Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
.../opensearch/common/util/BatchRunnableExecutor.java 50.00% 1 Missing ⚠️
.../opensearch/gateway/BaseGatewayShardAllocator.java 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #15648      +/-   ##
============================================
+ Coverage     71.63%   71.66%   +0.03%     
- Complexity    64016    64050      +34     
============================================
  Files          5249     5249              
  Lines        299681   299689       +8     
  Branches      43643    43643              
============================================
+ Hits         214667   214782     +115     
+ Misses        66999    66948      -51     
+ Partials      18015    17959      -56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Bukhtawar Bukhtawar merged commit 3fa710b into opensearch-project:2.x Sep 4, 2024
65 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants