Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add path prefix support to hashed prefix snapshots #15664

Merged
merged 6 commits into from
Sep 5, 2024

Conversation

ashking94
Copy link
Member

@ashking94 ashking94 commented Sep 4, 2024

Description

Add path prefix support to hashed prefix snapshots. This is built on top of #15557.

Check List

  • Functionality includes testing.
  • [ ] API changes companion pull request created, if applicable.
  • [ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Ashish Singh <ssashish@amazon.com>
Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for 14e442c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for 55102e6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Ashish Singh <ssashish@amazon.com>
@opensearch-project opensearch-project deleted a comment from github-actions bot Sep 4, 2024
@opensearch-project opensearch-project deleted a comment from github-actions bot Sep 4, 2024
Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for c6a04d1: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.17 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.17
# Create a new branch
git switch --create backport/backport-15664-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 245fa4703d1b61bfa07f881e82d2ff9ac8a2e064
# Push it to GitHub
git push --set-upstream origin backport/backport-15664-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.17

Then, create a pull request where the base branch is 2.17 and the compare/head branch is backport/backport-15664-to-2.17.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15664-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 245fa4703d1b61bfa07f881e82d2ff9ac8a2e064
# Push it to GitHub
git push --set-upstream origin backport/backport-15664-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-15664-to-2.x.

ashking94 added a commit to ashking94/OpenSearch that referenced this pull request Sep 5, 2024
…t#15664)

* Add path prefix support to hashed prefix snapshots

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Fix test

Signed-off-by: Ashish Singh <ssashish@amazon.com>

---------

Signed-off-by: Ashish Singh <ssashish@amazon.com>
ashking94 added a commit to ashking94/OpenSearch that referenced this pull request Sep 5, 2024
…t#15664)

* Add path prefix support to hashed prefix snapshots

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Fix test

Signed-off-by: Ashish Singh <ssashish@amazon.com>

---------

Signed-off-by: Ashish Singh <ssashish@amazon.com>
ashking94 added a commit to ashking94/OpenSearch that referenced this pull request Sep 5, 2024
…t#15664)

* Add path prefix support to hashed prefix snapshots

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Fix test

Signed-off-by: Ashish Singh <ssashish@amazon.com>

---------

Signed-off-by: Ashish Singh <ssashish@amazon.com>
ashking94 added a commit that referenced this pull request Sep 6, 2024
* Add path prefix support to hashed prefix snapshots



* Fix test



---------

Signed-off-by: Ashish Singh <ssashish@amazon.com>
ashking94 added a commit that referenced this pull request Sep 9, 2024
* Add path prefix support to hashed prefix snapshots



* Fix test



---------

Signed-off-by: Ashish Singh <ssashish@amazon.com>
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
…t#15664)

* Add path prefix support to hashed prefix snapshots

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Fix test

Signed-off-by: Ashish Singh <ssashish@amazon.com>

---------

Signed-off-by: Ashish Singh <ssashish@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants