Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CircuitBreakingException for too many shards in snapshot status API call #15688

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

ltaragi
Copy link
Contributor

@ltaragi ltaragi commented Sep 4, 2024

Description

Throw CircuitBreakingException for too many shards in snapshot status API call

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ltaragi ltaragi self-assigned this Sep 4, 2024
Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for aa93482: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@ltaragi ltaragi force-pushed the snapshot-status-exception branch from aa93482 to 02e9680 Compare September 4, 2024 18:04
Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for 02e9680: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

…API call

Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
@ltaragi ltaragi force-pushed the snapshot-status-exception branch from 02e9680 to 7f9955c Compare September 4, 2024 18:13
Copy link
Contributor

github-actions bot commented Sep 4, 2024

✅ Gradle check result for 7f9955c: SUCCESS

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 71.88%. Comparing base (e087272) to head (7f9955c).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
...apshots/status/TransportSnapshotsStatusAction.java 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #15688      +/-   ##
============================================
- Coverage     72.00%   71.88%   -0.13%     
+ Complexity    64149    64068      -81     
============================================
  Files          5269     5269              
  Lines        299834   299869      +35     
  Branches      43330    43340      +10     
============================================
- Hits         215895   215549     -346     
- Misses        66217    66565     +348     
- Partials      17722    17755      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gbbafna gbbafna merged commit f33c786 into opensearch-project:main Sep 5, 2024
56 of 57 checks passed
@gbbafna gbbafna added backport 2.x Backport to 2.x branch backport 2.17 labels Sep 5, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 5, 2024
…API call (#15688)

Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
(cherry picked from commit f33c786)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 5, 2024
…API call (#15688)

Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
(cherry picked from commit f33c786)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sachinpkale pushed a commit that referenced this pull request Sep 5, 2024
…API call (#15688) (#15720)

(cherry picked from commit f33c786)

Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gbbafna pushed a commit that referenced this pull request Sep 5, 2024
…API call (#15688) (#15719)

(cherry picked from commit f33c786)

Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
…API call (opensearch-project#15688)

Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
…API call (opensearch-project#15688)

Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
…API call (opensearch-project#15688)

Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
…API call (opensearch-project#15688)

Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants