Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] [RW Separation] Add routing preference to route requests only to search replicas. #15690

Merged
merged 1 commit into from
Sep 4, 2024
Merged

[Backport 2.x] [RW Separation] Add routing preference to route requests only to search replicas. #15690

merged 1 commit into from
Sep 4, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 3681b52 from #15563.

@github-actions
[RW Separation] Add routing preference to route requests only to sear…
c62aeda 
…ch replicas. (#15563)

* Add routing preference to route requests only to search replicas.

This adds SEARCH_REPLICA routing preference and defaults to this preference
for indices that have search replicas.

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>

* add changelog entry

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>

* PR feedback - extract a private method for replica filtering

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>

* remove changelog entry

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>

---------

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
(cherry picked from commit 3681b52)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for c62aeda:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024

❕ Gradle check result for c62aeda: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov Codecov
Copy link

codecov bot commented Sep 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.

Project coverage is 71.71%. Comparing base (d2ae53e) to head (c62aeda).
Report is 2 commits behind head on 2.x.

Files with missing lines Patch % Lines
...g/opensearch/cluster/routing/OperationRouting.java 66.66% 0 Missing and 2 partials ⚠️
...search/cluster/routing/IndexShardRoutingTable.java 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #15690      +/-   ##
============================================
+ Coverage     71.60%   71.71%   +0.11%     
- Complexity    64190    64257      +67     
============================================
  Files          5251     5251              
  Lines        300493   300504      +11     
  Branches      43741    43745       +4     
============================================
+ Hits         215160   215504     +344     
+ Misses        67333    66975     -358     
- Partials      18000    18025      +25

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mch2 mch2 merged commit b787753 into 2.x Sep 4, 2024
61 of 63 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 4, 2024
@github-actions
[RW Separation] Add routing preference to route requests only to sear…
26e16e3 
…ch replicas. (#15563) (#15690)

* Add routing preference to route requests only to search replicas.

This adds SEARCH_REPLICA routing preference and defaults to this preference
for indices that have search replicas.

* add changelog entry

* PR feedback - extract a private method for replica filtering

* remove changelog entry

---------

(cherry picked from commit 3681b52)

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit b787753)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 4, 2024
Merged
mch2 pushed a commit that referenced this pull request Sep 4, 2024
@opensearch-trigger-bot @github-actions
[RW Separation] Add routing preference to route requests only to sear…
a3312b4 
…ch replicas. (#15563) (#15690) (#15699)

* Add routing preference to route requests only to search replicas.

This adds SEARCH_REPLICA routing preference and defaults to this preference
for indices that have search replicas.

* add changelog entry

* PR feedback - extract a private method for replica filtering

* remove changelog entry

---------

(cherry picked from commit 3681b52)




(cherry picked from commit b787753)

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Sep 6, 2024
Open
Open
Open
@andrross andrross deleted the backport/backport-15563-to-2.x branch October 17, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mch2 mch2 mch2 approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
backport 2.17 skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mch2