-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Fix approximate pointrangequery tests #15704
Conversation
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> (cherry picked from commit 4f57d6a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #15704 +/- ##
============================================
+ Coverage 71.68% 71.76% +0.08%
- Complexity 64300 64344 +44
============================================
Files 5255 5255
Lines 300776 300779 +3
Branches 43811 43812 +1
============================================
+ Hits 215597 215847 +250
+ Misses 67181 66908 -273
- Partials 17998 18024 +26 ☔ View full report in Codecov by Sentry. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/backport-2.17
# Create a new branch
git switch --create backport/backport-15704-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 017f7d461ca865da57948719db0b58f40286427c
# Push it to GitHub
git push --set-upstream origin backport/backport-15704-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.17 Then, create a pull request where the |
Whoops! Forgot to merge the commit that introduced the test before triggering the backport for the test fix. Removing / readding the backport 2.17 tag... |
(cherry picked from commit 4f57d6a) Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit 017f7d4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Backport 4f57d6a from #15590.