Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2.18.0 version #15712

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Add 2.18.0 version #15712

merged 1 commit into from
Sep 5, 2024

Conversation

reta
Copy link
Collaborator

@reta reta commented Sep 5, 2024

Description

Add 2.18.0 version

Related Issues

Needs #15680 first

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Sep 5, 2024

❌ Gradle check result for 36b344c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 5, 2024

❌ Gradle check result for 36b344c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@harshavamsi
Copy link
Contributor

Gradle bwc checks are failing without this since 2.17 is already cut, can we merge this for bwc?

@harshavamsi
Copy link
Contributor

@sachinpkale can we merge this?

❌ Gradle check result for 36b344c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

org.opensearch.index.engine.NRTReplicationEngineTests.testGetSegmentInfosSnapshotPreservesFilesUntilRelease -- flaky test

@msfroh
Copy link
Collaborator

msfroh commented Sep 5, 2024

If there's a flaky test, we need to fix the flaky tests.

Copy link
Contributor

github-actions bot commented Sep 5, 2024

❌ Gradle check result for 36b344c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@shiv0408
Copy link
Member

shiv0408 commented Sep 5, 2024

Reverting #15680 will unblock mp

Reverting will mean that we'll go back to two different branches linked to the same version, despite being in different states.

There should be a very quick series of steps:

1. Cut the release branch.

2. Update the 2.x branch

3. Update the main branch.

It's hard to do that when everyone is cramming changes into the main, 2.x, and release branches, though.

(See opensearch-project/opensearch-build#4909 (comment))

All our lives would have been easier if the release branch cut was post code freeze. Build failing because of this version bump or jenkins hosts choking on sheer number of build requests. So, +1 for branch cut post "freeze" from next release.

Copy link
Contributor

github-actions bot commented Sep 5, 2024

❌ Gradle check result for 36b344c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@sohami
Copy link
Collaborator

sohami commented Sep 5, 2024

❌ Gradle check result for 36b344c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

It seems like it is taking wrong commit on 2.x: ?

> Task :distribution:bwc:minor:checkoutBwcBranch
Commit date of current: 'Wed, 4 Sep 2024 21:30:23 -0400'
Performing checkout of opensearch-project/2.x...
Checkout hash for :distribution:bwc:minor is b44242d47ee70ddc9a22932befda65ba739cd189

@shiv0408
Copy link
Member

shiv0408 commented Sep 5, 2024

❌ Gradle check result for 36b344c: FAILURE
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

It seems like it is taking wrong commit on 2.x: ?

> Task :distribution:bwc:minor:checkoutBwcBranch
Commit date of current: 'Wed, 4 Sep 2024 21:30:23 -0400'
Performing checkout of opensearch-project/2.x...
Checkout hash for :distribution:bwc:minor is b44242d47ee70ddc9a22932befda65ba739cd189

Happened last time also. #15053 (comment)

Seems like can't do anything apart from retrying.

@shiv0408 shiv0408 closed this Sep 5, 2024
@shiv0408 shiv0408 reopened this Sep 5, 2024
@shiv0408
Copy link
Member

shiv0408 commented Sep 5, 2024

Closed by mistake, Sorry.

Copy link
Contributor

github-actions bot commented Sep 5, 2024

❌ Gradle check result for 36b344c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 5, 2024

❌ Gradle check result for 36b344c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@shiv0408
Copy link
Member

shiv0408 commented Sep 5, 2024

❌ Gradle check result for 36b344c: FAILURE

Flaky: #14012

Which is closed:

Closing for now since it does not yet manifests in any merged code

Originally posted by @reta in #14012 (comment)

Copy link
Contributor

github-actions bot commented Sep 5, 2024

❌ Gradle check result for 36b344c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@shiv0408 shiv0408 closed this Sep 5, 2024
@shiv0408 shiv0408 reopened this Sep 5, 2024
Copy link
Contributor

github-actions bot commented Sep 5, 2024

❌ Gradle check result for 36b344c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 5, 2024

✅ Gradle check result for d43a892: SUCCESS

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.92%. Comparing base (729e40d) to head (03fda15).
Report is 8 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #15712      +/-   ##
============================================
- Coverage     71.95%   71.92%   -0.04%     
+ Complexity    64192    64185       -7     
============================================
  Files          5270     5271       +1     
  Lines        300052   300166     +114     
  Branches      43368    43380      +12     
============================================
- Hits         215917   215898      -19     
- Misses        66442    66526      +84     
- Partials      17693    17742      +49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dblock
Copy link
Member

dblock commented Sep 5, 2024

Looks like MacOS builds are stuck. Do you know why @reta? Not sure I understand what's going on.

@reta
Copy link
Collaborator Author

reta commented Sep 5, 2024

Looks like MacOS builds are stuck. Do you know why @reta? Not sure I understand what's going on.

#15741

@reta
Copy link
Collaborator Author

reta commented Sep 5, 2024

The MacOS assemble checks should be "fixed" now: #15741

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Copy link
Contributor

github-actions bot commented Sep 5, 2024

✅ Gradle check result for 03fda15: SUCCESS

@reta reta merged commit 2f1e209 into opensearch-project:main Sep 5, 2024
32 checks passed
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants