Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade version check for ser/de of applyLevelAtTransportLayer flag… #15803

Merged

Conversation

SwethaGuptha
Copy link
Contributor

… in ClusterHealthRequest

Description

#15492 - Downgrade version check for ser/de of applyLevelAtTransportLayer flag in ClusterHealthRequest

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Sep 6, 2024

❌ Gradle check result for f2ecd71: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 6, 2024

❌ Gradle check result for f2ecd71: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 6, 2024

❌ Gradle check result for f2ecd71: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@jed326 jed326 force-pushed the version-downgrage-15492 branch from f2ecd71 to a74596b Compare September 6, 2024 18:18
Copy link
Contributor

github-actions bot commented Sep 6, 2024

❌ Gradle check result for a74596b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@SwethaGuptha SwethaGuptha force-pushed the version-downgrage-15492 branch from a74596b to eea2ef8 Compare September 7, 2024 04:21
Copy link
Contributor

github-actions bot commented Sep 7, 2024

❌ Gradle check result for eea2ef8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

… in ClusterHealthRequest

Signed-off-by: Swetha Guptha <gupthasg@amazon.com>
@SwethaGuptha SwethaGuptha force-pushed the version-downgrage-15492 branch from eea2ef8 to 13cf320 Compare September 7, 2024 09:27
Copy link
Contributor

github-actions bot commented Sep 7, 2024

❌ Gradle check result for eea2ef8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 7, 2024

❌ Gradle check result for 13cf320: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@sachinpkale
Copy link
Member

@SwethaGuptha Regarding this failure: https://build.ci.opensearch.org/job/gradle-check/47533/, please rebase the changes on latest main

@SwethaGuptha
Copy link
Contributor Author

@SwethaGuptha Regarding this failure: https://build.ci.opensearch.org/job/gradle-check/47533/, please rebase the changes on latest main

Done.

Copy link
Contributor

github-actions bot commented Sep 7, 2024

✅ Gradle check result for ab8101e: SUCCESS

Copy link

codecov bot commented Sep 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.85%. Comparing base (0f29b52) to head (ab8101e).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...ion/admin/cluster/health/ClusterHealthRequest.java 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #15803      +/-   ##
============================================
+ Coverage     71.84%   71.85%   +0.01%     
- Complexity    64198    64217      +19     
============================================
  Files          5272     5272              
  Lines        300538   300538              
  Branches      43432    43432              
============================================
+ Hits         215915   215963      +48     
- Misses        66841    66862      +21     
+ Partials      17782    17713      -69     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gbbafna gbbafna merged commit 767c07f into opensearch-project:main Sep 8, 2024
33 of 34 checks passed
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
… in ClusterHealthRequest (opensearch-project#15803)

Signed-off-by: Swetha Guptha <gupthasg@amazon.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
… in ClusterHealthRequest (opensearch-project#15803)

Signed-off-by: Swetha Guptha <gupthasg@amazon.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
… in ClusterHealthRequest (opensearch-project#15803)

Signed-off-by: Swetha Guptha <gupthasg@amazon.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
… in ClusterHealthRequest (opensearch-project#15803)

Signed-off-by: Swetha Guptha <gupthasg@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants