Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmute snapshot status tests from #15652 #15876

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

ltaragi
Copy link
Contributor

@ltaragi ltaragi commented Sep 10, 2024

Description

This reverts commit 48cf5f0 (#15652)

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ltaragi ltaragi self-assigned this Sep 10, 2024
Copy link
Contributor

❕ Gradle check result for c52575c: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.84%. Comparing base (7cb2bd0) to head (e7fdcac).
Report is 19 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #15876      +/-   ##
============================================
- Coverage     71.85%   71.84%   -0.01%     
+ Complexity    64213    64190      -23     
============================================
  Files          5272     5272              
  Lines        300538   300538              
  Branches      43432    43432              
============================================
- Hits         215947   215932      -15     
- Misses        66833    66868      +35     
+ Partials      17758    17738      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ltaragi
Copy link
Contributor Author

ltaragi commented Sep 10, 2024

❕ Gradle check result for c52575c: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Flaky tests: #14291, #15806

Copy link
Contributor

❌ Gradle check result for c52575c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@ltaragi
Copy link
Contributor Author

ltaragi commented Sep 11, 2024

❌ Gradle check result for c52575c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Flaky test #14295

Copy link
Contributor

✅ Gradle check result for ffd4386: SUCCESS

Copy link
Contributor

✅ Gradle check result for b7eb368: SUCCESS

This reverts commit 48cf5f0.

Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
Copy link
Contributor

✅ Gradle check result for e7fdcac: SUCCESS

@ltaragi
Copy link
Contributor Author

ltaragi commented Sep 11, 2024

As the tests were not reproducible locally, we have run 5 gradle builds with the unmuted tests and didn't see any failures associated with them.

@sachinpkale sachinpkale merged commit c709400 into opensearch-project:main Sep 16, 2024
59 checks passed
@sachinpkale sachinpkale added backport 2.x Backport to 2.x branch backport 2.17 and removed backport 2.17 labels Sep 16, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 16, 2024
This reverts commit 48cf5f0.

Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
(cherry picked from commit c709400)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.17 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.17
# Create a new branch
git switch --create backport/backport-15876-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c709400543a16d7f7d6d644f26bb2f7a10b90caf
# Push it to GitHub
git push --set-upstream origin backport/backport-15876-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.17

Then, create a pull request where the base branch is 2.17 and the compare/head branch is backport/backport-15876-to-2.17.

dblock pushed a commit that referenced this pull request Sep 19, 2024
This reverts commit 48cf5f0.


(cherry picked from commit c709400)

Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sachinpkale pushed a commit to sachinpkale/OpenSearch that referenced this pull request Sep 19, 2024
opensearch-project#15876)

This reverts commit 48cf5f0.

Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants