Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [BUG] Bug fix for checksum validation for mapping metadata #15888 #15890

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

himshikha
Copy link
Contributor

Description

Backport f8515c7 from #15885.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…h-project#15885)

* Bug fix for checksum validation for mapping metadata

Signed-off-by: Himshikha Gupta <himshikh@amazon.com>
Copy link
Contributor

✅ Gradle check result for cbb16d5: SUCCESS

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.54%. Comparing base (dc28eb2) to head (cbaf0d2).
Report is 3 commits behind head on 2.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #15890      +/-   ##
============================================
+ Coverage     71.46%   71.54%   +0.07%     
- Complexity    64439    64444       +5     
============================================
  Files          5264     5264              
  Lines        302012   302052      +40     
  Branches      43970    43970              
============================================
+ Hits         215831   216101     +270     
+ Misses        68148    67882     -266     
- Partials      18033    18069      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@himshikha himshikha force-pushed the remote-checksum-fix-2x branch from cbb16d5 to 4e2ddcb Compare September 11, 2024 11:42
Copy link
Contributor

❕ Gradle check result for 4e2ddcb: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests.testWriteRead
      1 org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests.testSnapshotWithLargeSegmentFiles
      1 org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests.testSnapshotAndRestore
      1 org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests.testRequestStats
      1 org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests.testReadNonExistingPath
      1 org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests.testMultipleSnapshotAndRollback
      1 org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests.testIndicesDeletedFromRepository
      1 org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests.testDeleteBlobs

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Signed-off-by: Himshikha Gupta <himshikh@amazon.com>
@himshikha himshikha force-pushed the remote-checksum-fix-2x branch from 4e2ddcb to 4d67722 Compare September 11, 2024 13:03
Copy link
Contributor

❕ Gradle check result for 4d67722: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link
Contributor

❌ Gradle check result for cbaf0d2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@himshikha
Copy link
Contributor Author

❌ Gradle check result for cbaf0d2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Flaky tests #14289, #14288, #15806

Copy link
Contributor

❕ Gradle check result for cbaf0d2: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@Bukhtawar Bukhtawar merged commit 1074c71 into opensearch-project:2.x Sep 12, 2024
34 of 35 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 12, 2024
…adata #15888  (#15890)

* [BUG] Bug fix for checksum validation for mapping metadata (#15885)

* Bug fix for checksum validation for mapping metadata

Signed-off-by: Himshikha Gupta <himshikh@amazon.com>
(cherry picked from commit 1074c71)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Bukhtawar pushed a commit that referenced this pull request Sep 12, 2024
…adata #15888  (#15890) (#15908)

* [BUG] Bug fix for checksum validation for mapping metadata (#15885)

Signed-off-by: Himshikha Gupta <himshikh@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants