-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for msearch API to pass search pipeline name #15923
Added support for msearch API to pass search pipeline name #15923
Conversation
f64a7cb
to
a6a64ee
Compare
❌ Gradle check result for a6a64ee: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❕ Gradle check result for a6a64ee: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15923 +/- ##
============================================
+ Coverage 71.96% 71.98% +0.02%
- Complexity 64391 64418 +27
============================================
Files 5280 5280
Lines 300866 300886 +20
Branches 43474 43480 +6
============================================
+ Hits 216510 216589 +79
+ Misses 66639 66495 -144
- Partials 17717 17802 +85 ☔ View full report in Codecov by Sentry. |
@msfroh can I get another review on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks, @owaiskazi19!
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15923-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 daf1669b7ca77c62fc82ba9162d3708702b13fce
# Push it to GitHub
git push --set-upstream origin backport/backport-15923-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
…h-project#15923) * Added support for search pipeline name in multi search API Signed-off-by: Owais <owaiskazi19@gmail.com> * Updated CHANGELOG Signed-off-by: Owais <owaiskazi19@gmail.com> * Pulled search pipeline in MultiSearchRequest and updated test Signed-off-by: Owais <owaiskazi19@gmail.com> * Updated test Signed-off-by: Owais <owaiskazi19@gmail.com> * Updated SearchRequest with search pipeline from source Signed-off-by: Owais <owaiskazi19@gmail.com> * Added tests for parseSearchRequest Signed-off-by: Owais <owaiskazi19@gmail.com> * Guard serialization with version check Signed-off-by: Owais <owaiskazi19@gmail.com> * Updated version and added another test for serialization Signed-off-by: Owais <owaiskazi19@gmail.com> --------- Signed-off-by: Owais <owaiskazi19@gmail.com>
@owaiskazi19 I'll merge both of these tomorrow morning. I've made the mistake of merging the first PR then going to sleep a few too many times. 😀 |
…name (#16085) * Added support for msearch API to pass search pipeline name (#15923) * Added support for search pipeline name in multi search API Signed-off-by: Owais <owaiskazi19@gmail.com> * Updated CHANGELOG Signed-off-by: Owais <owaiskazi19@gmail.com> * Pulled search pipeline in MultiSearchRequest and updated test Signed-off-by: Owais <owaiskazi19@gmail.com> * Updated test Signed-off-by: Owais <owaiskazi19@gmail.com> * Updated SearchRequest with search pipeline from source Signed-off-by: Owais <owaiskazi19@gmail.com> * Added tests for parseSearchRequest Signed-off-by: Owais <owaiskazi19@gmail.com> * Guard serialization with version check Signed-off-by: Owais <owaiskazi19@gmail.com> * Updated version and added another test for serialization Signed-off-by: Owais <owaiskazi19@gmail.com> --------- Signed-off-by: Owais <owaiskazi19@gmail.com> * Updated version to 2.18 Signed-off-by: Owais <owaiskazi19@gmail.com> --------- Signed-off-by: Owais <owaiskazi19@gmail.com>
This is an API change, isn't it? It needs changes in api-specification repo please? |
…h-project#15923) * Added support for search pipeline name in multi search API Signed-off-by: Owais <owaiskazi19@gmail.com> * Updated CHANGELOG Signed-off-by: Owais <owaiskazi19@gmail.com> * Pulled search pipeline in MultiSearchRequest and updated test Signed-off-by: Owais <owaiskazi19@gmail.com> * Updated test Signed-off-by: Owais <owaiskazi19@gmail.com> * Updated SearchRequest with search pipeline from source Signed-off-by: Owais <owaiskazi19@gmail.com> * Added tests for parseSearchRequest Signed-off-by: Owais <owaiskazi19@gmail.com> * Guard serialization with version check Signed-off-by: Owais <owaiskazi19@gmail.com> * Updated version and added another test for serialization Signed-off-by: Owais <owaiskazi19@gmail.com> --------- Signed-off-by: Owais <owaiskazi19@gmail.com>
…h-project#15923) * Added support for search pipeline name in multi search API Signed-off-by: Owais <owaiskazi19@gmail.com> * Updated CHANGELOG Signed-off-by: Owais <owaiskazi19@gmail.com> * Pulled search pipeline in MultiSearchRequest and updated test Signed-off-by: Owais <owaiskazi19@gmail.com> * Updated test Signed-off-by: Owais <owaiskazi19@gmail.com> * Updated SearchRequest with search pipeline from source Signed-off-by: Owais <owaiskazi19@gmail.com> * Added tests for parseSearchRequest Signed-off-by: Owais <owaiskazi19@gmail.com> * Guard serialization with version check Signed-off-by: Owais <owaiskazi19@gmail.com> * Updated version and added another test for serialization Signed-off-by: Owais <owaiskazi19@gmail.com> --------- Signed-off-by: Owais <owaiskazi19@gmail.com>
…h-project#15923) * Added support for search pipeline name in multi search API Signed-off-by: Owais <owaiskazi19@gmail.com> * Updated CHANGELOG Signed-off-by: Owais <owaiskazi19@gmail.com> * Pulled search pipeline in MultiSearchRequest and updated test Signed-off-by: Owais <owaiskazi19@gmail.com> * Updated test Signed-off-by: Owais <owaiskazi19@gmail.com> * Updated SearchRequest with search pipeline from source Signed-off-by: Owais <owaiskazi19@gmail.com> * Added tests for parseSearchRequest Signed-off-by: Owais <owaiskazi19@gmail.com> * Guard serialization with version check Signed-off-by: Owais <owaiskazi19@gmail.com> * Updated version and added another test for serialization Signed-off-by: Owais <owaiskazi19@gmail.com> --------- Signed-off-by: Owais <owaiskazi19@gmail.com>
…h-project#15923) * Added support for search pipeline name in multi search API Signed-off-by: Owais <owaiskazi19@gmail.com> * Updated CHANGELOG Signed-off-by: Owais <owaiskazi19@gmail.com> * Pulled search pipeline in MultiSearchRequest and updated test Signed-off-by: Owais <owaiskazi19@gmail.com> * Updated test Signed-off-by: Owais <owaiskazi19@gmail.com> * Updated SearchRequest with search pipeline from source Signed-off-by: Owais <owaiskazi19@gmail.com> * Added tests for parseSearchRequest Signed-off-by: Owais <owaiskazi19@gmail.com> * Guard serialization with version check Signed-off-by: Owais <owaiskazi19@gmail.com> * Updated version and added another test for serialization Signed-off-by: Owais <owaiskazi19@gmail.com> --------- Signed-off-by: Owais <owaiskazi19@gmail.com>
Description
Added support for msearch API to pass search pipeline name.
With this change a search pipeline name can be provided while making a msearch call
Related Issues
Resolves #15748
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.