Fixing flaky test testRemoteIndexPathFileExistsAfterMigration #15977
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Gradle check result for 6e0d4f2: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
added 2 commits
September 20, 2024 14:34
Signed-off-by: Shubh Sahu <shubhvs@amazon.com>
Signed-off-by: Shubh Sahu <shubhvs@amazon.com>
astute-decipher
force-pushed
the
flakytest
branch
from
6e0d4f2
to
090c296
Compare
astute-decipher
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
|
❌ Gradle check result for 090c296: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing flaky testRemoteIndexPathFileExistsAfterMigration IT. We currently have a hard check on remote-index-path file, and this is resulting into flakiness when indexMetadata changes across runs. We can have a bit lighter check and we can check if
indexUUIDexists in path file name instead ofindexUUID#indexMetadataVersion#RemoteIndexPathVersion. Sample file name :remote_path_0kxx2-Y3RqGi9KfxXzqd9A#6#1#zB8i07rPTIWMbYZCgHp0KgRelated Issues
Resolves [#14295]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.