Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly set the include discovery nodes flag for reload secure setting request. #15998

Open
wants to merge 1 commit into
base: 2.17
Choose a base branch
from

Conversation

SwethaGuptha
Copy link
Contributor

Description

Backport 620db0a from #15972.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…quest.

Signed-off-by: Swetha Guptha <gupthasg@amazon.com>
(cherry picked from commit 620db0a)
Signed-off-by: Swetha Guptha <gupthasg@amazon.com>
Copy link
Contributor

✅ Gradle check result for 5b3945c: SUCCESS

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.65%. Comparing base (5c586ef) to head (5b3945c).
Report is 3 commits behind head on 2.17.

Files with missing lines Patch % Lines
.../node/reload/NodesReloadSecureSettingsRequest.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               2.17   #15998      +/-   ##
============================================
+ Coverage     71.64%   71.65%   +0.01%     
+ Complexity    64580    64524      -56     
============================================
  Files          5264     5264              
  Lines        302101   302102       +1     
  Branches      43976    43976              
============================================
+ Hits         216427   216466      +39     
+ Misses        67658    67483     -175     
- Partials      18016    18153     +137     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added the stalled Issues that have stalled label Oct 19, 2024
@dbwiddis
Copy link
Member

@SwethaGuptha This is a backport to 2.17 which is already released. Does it still need to be reviewed/approved?

@opensearch-trigger-bot opensearch-trigger-bot bot removed the stalled Issues that have stalled label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants