Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed suspicious call of getClass() on instance of Class, which erased type info #16002

Merged
merged 3 commits into from
Oct 18, 2024
Merged

Removed suspicious call of getClass() on instance of Class, which erased type info #16002

merged 3 commits into from
Oct 18, 2024

Conversation

dk2k
Copy link
Contributor

@dk2k dk2k commented Sep 19, 2024

Added unit test.
Previous PR was prematurely closed #15367 without letting me react upon the comment.

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 10a87e2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@dblock
Copy link
Member

dblock commented Sep 24, 2024

getName looks much better, thanks for doing this and for fixing the comment typo.

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 10a87e2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

sandeshkr419
sandeshkr419 approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@sandeshkr419 sandeshkr419 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding test-case as well for these changes. LGTM!

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 10a87e2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@dblock
Copy link
Member

dblock commented Sep 26, 2024

Odd failure

* What went wrong:
Execution failed for task ':libs:opensearch-core:licenseHeaders'.
> License header problems were found! Full details: /var/jenkins/workspace/gradle-check/search/libs/core/build/reports/licenseHeaders/rat.log

Rebase?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for f7b722f: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for f7b722f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@dblock
Copy link
Member

dblock commented Sep 30, 2024

I am not sure what's going on, but the license header check doesn't happen elsewhere, so something is off in this PR. Rebase it instead of merging from main and force push an update?

@dk2k
Copy link
Contributor Author

dk2k commented Oct 2, 2024

I rebased

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

❌ Gradle check result for f3a4ea4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for f3a4ea4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@dk2k @dbwiddis
Removed suspicious getClass() call on Class
b88f872 
Signed-off-by: Dmitry Kryukov <dk2k@ya.ru>
@dk2k @dbwiddis
Changed the exception's message. Added unit test.
f4786bf 
Signed-off-by: Dmitry Kryukov <dk2k@ya.ru>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for f4786bf: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@dbwiddis
Run spotless, add license header
4142a28 
Signed-off-by: Daniel Widdis <widdis@gmail.com>
@dbwiddis
Copy link
Member

Odd failure

* What went wrong:
Execution failed for task ':libs:opensearch-core:licenseHeaders'.
> License header problems were found! Full details: /var/jenkins/workspace/gradle-check/search/libs/core/build/reports/licenseHeaders/rat.log

Rebase?

Checked out the PR, rebased and still failing precommit.

Ran locally to generate that log. The new test class had no license headers.

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 4142a28: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

This was referenced Oct 18, 2024
Open
Open
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 4142a28: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Oct 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.06%. Comparing base (dc8a435) to head (4142a28).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #16002      +/-   ##
============================================
+ Coverage     71.96%   72.06%   +0.10%     
- Complexity    64791    64849      +58     
============================================
  Files          5307     5307              
  Lines        302714   302725      +11     
  Branches      43733    43734       +1     
============================================
+ Hits         217836   218172     +336     
+ Misses        67013    66689     -324     
+ Partials      17865    17864       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbwiddis dbwiddis merged commit 4456d55 into opensearch-project:main Oct 18, 2024
38 checks passed
@dbwiddis dbwiddis added the backport 2.x Backport to 2.x branch label Oct 18, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 18, 2024
@github-actions @dbwiddis
Removed suspicious call of getClass() on instance of Class, which era…
de24c8c 
…sed type info (#16002)

* Removed suspicious getClass() call on Class

Signed-off-by: Dmitry Kryukov <dk2k@ya.ru>

* Changed the exception's message. Added unit test.

Signed-off-by: Dmitry Kryukov <dk2k@ya.ru>

* Run spotless, add license header

Signed-off-by: Daniel Widdis <widdis@gmail.com>

---------

Signed-off-by: Dmitry Kryukov <dk2k@ya.ru>
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Co-authored-by: Daniel Widdis <widdis@gmail.com>
(cherry picked from commit 4456d55)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 18, 2024
Merged
dbwiddis added a commit that referenced this pull request Oct 18, 2024
@opensearch-trigger-bot @github-actions @dbwiddis
Removed suspicious call of getClass() on instance of Class, which era…
c5941db 
…sed type info (#16002) (#16371)

* Removed suspicious getClass() call on Class



* Changed the exception's message. Added unit test.



* Run spotless, add license header



---------




(cherry picked from commit 4456d55)

Signed-off-by: Dmitry Kryukov <dk2k@ya.ru>
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Daniel Widdis <widdis@gmail.com>
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Oct 18, 2024
Open
@dbwiddis dbwiddis mentioned this pull request Oct 19, 2024
Closed
dk2k added a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
@dk2k @dbwiddis
Removed suspicious call of getClass() on instance of Class, which era…
e98974d 
…sed type info (opensearch-project#16002)

* Removed suspicious getClass() call on Class

Signed-off-by: Dmitry Kryukov <dk2k@ya.ru>

* Changed the exception's message. Added unit test.

Signed-off-by: Dmitry Kryukov <dk2k@ya.ru>

* Run spotless, add license header

Signed-off-by: Daniel Widdis <widdis@gmail.com>

---------

Signed-off-by: Dmitry Kryukov <dk2k@ya.ru>
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Co-authored-by: Daniel Widdis <widdis@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandeshkr419 sandeshkr419 sandeshkr419 approved these changes

@owaiskazi19 owaiskazi19 owaiskazi19 approved these changes

@dbwiddis dbwiddis dbwiddis approved these changes

@dblock dblock dblock approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dk2k @dblock @dbwiddis @owaiskazi19 @sandeshkr419