Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x Backport] Add successfulSearchShardIndices in searchRequestContext before onRequestEnd #16009

Open
wants to merge 2 commits into
base: 2.x
Choose a base branch
from

Conversation

dzane17
Copy link
Contributor

@dzane17 dzane17 commented Sep 19, 2024

Description

2.x Backport #15967

Related Issues

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…uestEnd (opensearch-project#15967)

Signed-off-by: David Zane <davizane@amazon.com>
Signed-off-by: Ankit Jain <akjain@amazon.com>
Co-authored-by: Ankit Jain <akjain@amazon.com>
(cherry picked from commit b369611)
Copy link
Contributor

❕ Gradle check result for a37fc20: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.snapshots.DedicatedClusterSnapshotRestoreIT.testSnapshotWithStuckNode

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.66%. Comparing base (448ae5e) to head (8d66170).

Files with missing lines Patch % Lines
...opensearch/action/search/SearchRequestContext.java 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #16009      +/-   ##
============================================
- Coverage     71.77%   71.66%   -0.11%     
+ Complexity    64687    64647      -40     
============================================
  Files          5277     5277              
  Lines        302344   302349       +5     
  Branches      43993    43993              
============================================
- Hits         217003   216676     -327     
- Misses        67223    67575     +352     
+ Partials      18118    18098      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Ankit Jain <akjain@amazon.com>
Copy link
Contributor

❕ Gradle check result for 8d66170: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.cluster.MinimumClusterManagerNodesIT.testThreeNodesNoClusterManagerBlock

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants