Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fix infinite loop in nested agg #16075

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

kkewwei
Copy link
Contributor

@kkewwei kkewwei commented Sep 25, 2024

Description

Backport 3953557 from #15931

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: kkewwei <kkewwei@163.com>
Copy link
Contributor

❕ Gradle check result for bb27833: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.74%. Comparing base (a12e3e6) to head (bb27833).
Report is 7 commits behind head on 2.x.

Files with missing lines Patch % Lines
...java/org/opensearch/index/mapper/ObjectMapper.java 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #16075      +/-   ##
============================================
- Coverage     71.75%   71.74%   -0.01%     
- Complexity    64708    64742      +34     
============================================
  Files          5278     5278              
  Lines        302570   302572       +2     
  Branches      44013    44014       +1     
============================================
- Hits         217098   217089       -9     
- Misses        67315    67385      +70     
+ Partials      18157    18098      -59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kkewwei
Copy link
Contributor Author

kkewwei commented Sep 26, 2024

@reta, please review when you are free.

@reta reta merged commit 2c7e8ed into opensearch-project:2.x Sep 26, 2024
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants