Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Optimize remote store GC flow with pinned timestamps #16077

Merged
merged 2 commits into from
Sep 25, 2024
Merged

[Backport 2.x] Optimize remote store GC flow with pinned timestamps #16077

merged 2 commits into from
Sep 25, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport dc4dbce from #15943.

@github-actions
Optimize remote store GC flow with pinned timestamps (#15943)
7dd7c38 
Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
(cherry picked from commit dc4dbce)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 7dd7c38: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Sep 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 52.80899% with 42 lines in your changes missing coverage. Please review.

Project coverage is 71.58%. Comparing base (a12e3e6) to head (2b4b9ec).
Report is 3 commits behind head on 2.x.

Files with missing lines Patch % Lines
...index/translog/RemoteFsTimestampAwareTranslog.java 48.07% 24 Missing and 3 partials ⚠️
...ch/repositories/blobstore/BlobStoreRepository.java 50.00% 6 Missing ⚠️
...earch/index/store/RemoteSegmentStoreDirectory.java 50.00% 3 Missing and 1 partial ⚠️
...ex/translog/transfer/TranslogTransferMetadata.java 40.00% 3 Missing ⚠️
...ava/org/opensearch/snapshots/SnapshotsService.java 50.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #16077      +/-   ##
============================================
- Coverage     71.75%   71.58%   -0.17%     
+ Complexity    64708    64641      -67     
============================================
  Files          5278     5278              
  Lines        302570   302614      +44     
  Branches      44013    44020       +7     
============================================
- Hits         217098   216637     -461     
- Misses        67315    67869     +554     
+ Partials      18157    18108      -49

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sachinpkale
Copy link
Member

Checking breaking changes.

@sachinpkale
Fix breaking changes
2b4b9ec 
Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

❕ Gradle check result for 2b4b9ec: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@ashking94 ashking94 merged commit a1846cf into 2.x Sep 25, 2024
34 of 35 checks passed
@github-actions github-actions bot deleted the backport/backport-15943-to-2.x branch September 25, 2024 16:21
This was referenced Sep 25, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashking94 ashking94 ashking94 approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sachinpkale @ashking94