Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unclosed store references with SearchOnlyReplicaIT #16106

Merged
merged 1 commit into from
Oct 22, 2024

Fix unclosed store references with node-node segrep when primary node…

9510a7b
Select commit
Loading
Failed to load commit list.
Merged

Fix unclosed store references with SearchOnlyReplicaIT #16106

Fix unclosed store references with node-node segrep when primary node…
9510a7b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 16, 2024 in 1s

71.96% (target 70.00%)

View this Pull Request on Codecov

71.96% (target 70.00%)

Details

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 71.96%. Comparing base (7caca26) to head (9510a7b).
Report is 96 commits behind head on main.

Files with missing lines Patch % Lines
...ces/replication/PrimaryShardReplicationSource.java 0.00% 0 Missing and 2 partials ⚠️
...s/replication/SegmentReplicationSourceFactory.java 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #16106      +/-   ##
============================================
- Coverage     72.04%   71.96%   -0.09%     
+ Complexity    64441    64434       -7     
============================================
  Files          5281     5281              
  Lines        301088   301094       +6     
  Branches      43500    43503       +3     
============================================
- Hits         216918   216673     -245     
- Misses        66438    66638     +200     
- Partials      17732    17783      +51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.