-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for restoring from snapshot with search replicas #16111
Add support for restoring from snapshot with search replicas #16111
Conversation
❌ Gradle check result for 7556720: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/snapshots/RestoreService.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/opensearch/cluster/routing/SearchOnlyReplicaRestoreTests.java
Outdated
Show resolved
Hide resolved
.../src/internalClusterTest/java/org/opensearch/indices/replication/SearchReplicaRestoreIT.java
Outdated
Show resolved
Hide resolved
.../src/internalClusterTest/java/org/opensearch/indices/replication/SearchReplicaRestoreIT.java
Outdated
Show resolved
Hide resolved
.../src/internalClusterTest/java/org/opensearch/indices/replication/SearchReplicaRestoreIT.java
Outdated
Show resolved
Hide resolved
.../src/internalClusterTest/java/org/opensearch/indices/replication/SearchReplicaRestoreIT.java
Outdated
Show resolved
Hide resolved
.../src/internalClusterTest/java/org/opensearch/indices/replication/SearchReplicaRestoreIT.java
Outdated
Show resolved
Hide resolved
.../src/internalClusterTest/java/org/opensearch/indices/replication/SearchReplicaRestoreIT.java
Outdated
Show resolved
Hide resolved
❌ Gradle check result for 7f03249: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for ca2fd04: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for ca2fd04: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>
❌ Gradle check result for 24d02df: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-16111-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9dd1a59847ad8c2716d002716521ac40afc69355
# Push it to GitHub
git push --set-upstream origin backport/backport-16111-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
…rch-project#16111) Signed-off-by: Vinay Krishna Pudyodu <pudyodu@amazon.com>
…rch-project#16111) Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>
…rch-project#16111) Signed-off-by: Vinay Krishna Pudyodu <pudyodu@amazon.com>
…rch-project#16111) Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>
…rch-project#16111) Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>
…rch-project#16111) Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>
…rch-project#16111) Signed-off-by: Vinaya Krishna Pudyodu <vinkrish.neo@gmail.com>
…rch-project#16111) Signed-off-by: Vinaya Krishna Pudyodu <vinkrish.neo@gmail.com>
…rch-project#16111) Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>
Description
In this PR we are adding,
DOCUMENT
andSEGMENT
replication type while snapshot restoration. Following are the allowed rules:DOCUMENT
can be restored toDOCUMENT
orSEGMENT
types. If we are restoring toSEGMENT
type more search replicas can be added.SEGMENT
and without any search replicas can be restored toDOCUMENT
orSEGMENT
types. If we are restoring toSEGMENT
type more search replicas can be added.SEGMENT
and with search replicas can be restored toDOCUMENT
orSEGMENT
types. If we are restoring toSEGMENT
type more search replicas can be added. If we are restoring toDOCUMENT
type search replica count must be set to 0 in the settings.Related Issues
Resolves #15532
Related #15306
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.