[Snapshot V2] Correct the version post backport to 2.18 instead of current for Snapshot Entry SerDe #16127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbbafna
changed the title
gbbafna
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
sachinpkale
approved these changes
Sep 30, 2024
|
❌ Gradle check result for abd7960: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
gbbafna
force-pushed
the
fix-version
branch
from
abd7960 to
ef4887c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16127 +/- ##
============================================
- Coverage 72.00% 71.94% -0.06%
- Complexity 64487 64507 +20
============================================
Files 5288 5288
Lines 301419 301423 +4
Branches 43549 43550 +1
============================================
- Hits 217026 216866 -160
- Misses 66587 66704 +117
- Partials 17806 17853 +47 ☔ View full report in Codecov by Sentry. |
sachinpkale
approved these changes
Sep 30, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 30, 2024
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> (cherry picked from commit 7ba8b78) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
hainenber
pushed a commit
to hainenber/OpenSearch
that referenced
this pull request
Oct 1, 2024
…rch-project#16127) Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
ruai0511
pushed a commit
to ruai0511/OpenSearch
that referenced
this pull request
Oct 4, 2024
…rch-project#16127) Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 16, 2024
…rch-project#16127) Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 17, 2024
…rch-project#16127) Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 21, 2024
…rch-project#16127) Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Post the backport #16102 , we need to make version 2.18 instead of Current (3.0)