Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Snapshot V2] Remove orphan timestamps post create snapshot completion #16148

Merged
merged 3 commits into from
Oct 3, 2024
Merged

[Snapshot V2] Remove orphan timestamps post create snapshot completion #16148

merged 3 commits into from
Oct 3, 2024

Conversation

gbbafna
Copy link
Collaborator

@gbbafna gbbafna commented Oct 1, 2024 •
edited
Loading

Description

We update pinned timestamps before finalizing the snapshot . In case post pinning timestamp, finalizing snapshot can fail . This leads to orphan pinned timestamps. This will leak data in remote store.

In this change, post every create snapshot operation, we find the orphan pinned timestamps and then unpin it .

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024

❌ Gradle check result for 0503f63: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

sachinpkale
sachinpkale reviewed Oct 1, 2024
View reviewed changes
server/src/main/java/org/opensearch/node/remotestore/RemoteStorePinnedTimestampService.java Outdated Show resolved Hide resolved
server/src/main/java/org/opensearch/node/remotestore/RemoteStorePinnedTimestampService.java Outdated Show resolved Hide resolved
server/src/main/java/org/opensearch/snapshots/SnapshotsService.java Outdated Show resolved Hide resolved
server/src/main/java/org/opensearch/snapshots/SnapshotsService.java Show resolved Hide resolved
server/src/main/java/org/opensearch/snapshots/SnapshotsService.java Outdated Show resolved Hide resolved
server/src/main/java/org/opensearch/node/remotestore/RemoteStorePinnedTimestampService.java Show resolved Hide resolved
server/src/main/java/org/opensearch/snapshots/SnapshotsService.java Show resolved Hide resolved
@gbbafna gbbafna marked this pull request as ready for review October 1, 2024 13:52
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024

❌ Gradle check result for d045995: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

This was referenced Oct 1, 2024
Closed
Open
gbbafna added 2 commits October 3, 2024 12:06
@gbbafna
Remove orphan timestamps post create snapshot completion
1bae64c 
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
@gbbafna
Address PR comments
48f147f 
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 3, 2024

❌ Gradle check result for 1cfb6c7: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@gbbafna
Address PR comments
14f0323 
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 3, 2024

✅ Gradle check result for 14f0323: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Oct 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 36.00000% with 32 lines in your changes missing coverage. Please review.

Project coverage is 72.08%. Comparing base (4e3a6d0) to head (14f0323).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...ava/org/opensearch/snapshots/SnapshotsService.java 24.24% 24 Missing and 1 partial ⚠️
...remotestore/RemoteStorePinnedTimestampService.java 58.82% 6 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #16148      +/-   ##
============================================
+ Coverage     71.91%   72.08%   +0.17%     
- Complexity    64491    64590      +99     
============================================
  Files          5289     5289              
  Lines        301509   301559      +50     
  Branches      43557    43563       +6     
============================================
+ Hits         216818   217370     +552     
+ Misses        66892    66393     -499     
+ Partials      17799    17796       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gbbafna gbbafna merged commit 6020c58 into opensearch-project:main Oct 3, 2024
33 of 34 checks passed
@gbbafna gbbafna added the backport 2.x Backport to 2.x branch label Oct 3, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 3, 2024
@github-actions
[Snapshot V2] Remove orphan timestamps post create snapshot completion (
0727abf 
#16148)

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
(cherry picked from commit 6020c58)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 3, 2024
Merged
sachinpkale pushed a commit that referenced this pull request Oct 3, 2024
@opensearch-trigger-bot @github-actions
[Snapshot V2] Remove orphan timestamps post create snapshot completion (
81f98eb 
#16148) (#16178)

(cherry picked from commit 6020c58)

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
@gbbafna @dk2k
[Snapshot V2] Remove orphan timestamps post create snapshot completion (
b99d02c 
opensearch-project#16148)

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
@gbbafna @dk2k
[Snapshot V2] Remove orphan timestamps post create snapshot completion (
ed2a958 
opensearch-project#16148)

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
@gbbafna @dk2k
[Snapshot V2] Remove orphan timestamps post create snapshot completion (
bf34227 
opensearch-project#16148)

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Nov 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sachinpkale sachinpkale sachinpkale approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gbbafna @sachinpkale