Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more unit tests for RemoteStoreUtils and RemoteFsTimestampAwareTranslog #16151

Merged
merged 5 commits into from
Oct 4, 2024
Merged

Add more unit tests for RemoteStoreUtils and RemoteFsTimestampAwareTranslog #16151

merged 5 commits into from
Oct 4, 2024

Conversation

sachinpkale
Copy link
Member

@sachinpkale sachinpkale commented Oct 1, 2024 •
edited
Loading

Description

  • Add more unit tests for code flows that are missing test coverage.

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024

❌ Gradle check result for 063f3fc: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024

✅ Gradle check result for 063f3fc: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Oct 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.86%. Comparing base (d1fd47c) to head (a84b06a).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #16151      +/-   ##
============================================
- Coverage     71.87%   71.86%   -0.01%     
+ Complexity    64528    64509      -19     
============================================
  Files          5296     5296              
  Lines        301744   301746       +2     
  Branches      43585    43586       +1     
============================================
- Hits         216864   216841      -23     
- Misses        67014    67080      +66     
+ Partials      17866    17825      -41

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 3, 2024

❌ Gradle check result for b42e759: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@sachinpkale
Add more unit tests for RemoteStoreUtils.getPinnedTimestampLockedFiles
152c6dc 
Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
@sachinpkale
Add unit tests for RemoteFsTimestampAwareTranslog.getMinMaxPrimaryTer…
32bd4ce 
…mFromMetadataFile

Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
@sachinpkale
Add unit tests for RemoteFsTimestampAwareTranslog.getMinPrimaryTermIn…
d11e97b 
…Remote

Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
@sachinpkale
Add more unit tests for RemoteFsTimestampAwareTranslog
f62a960 
Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
@sachinpkale
Address PR comments
a84b06a 
Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
@sachinpkale sachinpkale force-pushed the pinned-timestamp-tests branch from b42e759 to a84b06a Compare October 4, 2024 04:21
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024

❕ Gradle check result for a84b06a: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@gbbafna gbbafna merged commit aef7eca into opensearch-project:main Oct 4, 2024
34 checks passed
@gbbafna gbbafna added the backport 2.x Backport to 2.x branch label Oct 4, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 4, 2024
@github-actions
Add more unit tests for RemoteStoreUtils and RemoteFsTimestampAwareTr…
9f6a208 
…anslog (#16151)

Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
(cherry picked from commit aef7eca)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 4, 2024
Merged
sachinpkale pushed a commit that referenced this pull request Oct 4, 2024
@opensearch-trigger-bot @github-actions
Add more unit tests for RemoteStoreUtils and RemoteFsTimestampAwareTr…
66852cf 
…anslog (#16151) (#16186)

(cherry picked from commit aef7eca)

Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Oct 4, 2024
Open
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Oct 11, 2024
Open
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
@sachinpkale @dk2k
Add more unit tests for RemoteStoreUtils and RemoteFsTimestampAwareTr…
187b84a 
…anslog (opensearch-project#16151)

Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
@sachinpkale @dk2k
Add more unit tests for RemoteStoreUtils and RemoteFsTimestampAwareTr…
2ee4675 
…anslog (opensearch-project#16151)

Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
@sachinpkale @dk2k
Add more unit tests for RemoteStoreUtils and RemoteFsTimestampAwareTr…
1a9eba8 
…anslog (opensearch-project#16151)

Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbbafna gbbafna gbbafna approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sachinpkale @gbbafna