Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.x] Rename field_masking_span to span_field_masking (#1606) #1623

Merged

Conversation

xuezhou25
Copy link
Contributor

Signed-off-by: Xue Zhou xuezhou@amazon.com

Description

Backport PR#1606

Issues Resolved

Rename field_masking_span to span_field_masking as well as maintain backwards compatibility.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

)

* Rename field_masking_span to span_field_masking

Signed-off-by: Xue Zhou <xuezhou@amazon.com>

* Update SearchModuleTests.java

Signed-off-by: Xue Zhou <xuezhou@amazon.com>

* Rename field_masking_span to span_field_masking

Signed-off-by: Xue Zhou <xuezhou@amazon.com>
@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success ed7d1c7

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success ed7d1c7

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success ed7d1c7
Log 1261

Reports 1261

@dblock dblock merged commit f9ee754 into opensearch-project:1.x Nov 30, 2021
@xuezhou25 xuezhou25 deleted the Backport_remane_field_masking_span branch August 2, 2022 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants