Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changes to block calls in cat shards, indices and segments based … #16235

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

gargharsh3134
Copy link
Contributor

@gargharsh3134 gargharsh3134 commented Oct 8, 2024

…on dynamic limit settings (#15986)

  • Add changes to block calls in cat shards, indices and segments based on dynamic limit settings

Description

Backporting #15986

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…on dynamic limit settings (opensearch-project#15986)

* Add changes to block calls in cat shards, indices and segments based on dynamic limit settings

Signed-off-by: Sumit Bansal <sumitsb@amazon.com>
Copy link
Contributor

github-actions bot commented Oct 8, 2024

✅ Gradle check result for 5730ea5: SUCCESS

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 53.84615% with 54 lines in your changes missing coverage. Please review.

Project coverage is 71.68%. Comparing base (a12e3e6) to head (5730ea5).
Report is 59 commits behind head on 2.x.

Files with missing lines Patch % Lines
...common/breaker/ResponseLimitBreachedException.java 0.00% 18 Missing ⚠️
...admin/cluster/shards/TransportCatShardsAction.java 11.11% 8 Missing ⚠️
.../opensearch/rest/action/cat/RestIndicesAction.java 30.00% 7 Missing ⚠️
...opensearch/rest/action/cat/RestSegmentsAction.java 30.00% 7 Missing ⚠️
...ensearch/common/breaker/ResponseLimitSettings.java 88.88% 3 Missing and 3 partials ⚠️
.../action/admin/cluster/shards/CatShardsRequest.java 0.00% 4 Missing ⚠️
...g/opensearch/rest/action/cat/RestShardsAction.java 0.00% 2 Missing ⚠️
.../opensearch/rest/action/cat/AbstractCatAction.java 0.00% 1 Missing ⚠️
...search/rest/action/list/RestIndicesListAction.java 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #16235      +/-   ##
============================================
- Coverage     71.75%   71.68%   -0.07%     
- Complexity    64708    64930     +222     
============================================
  Files          5278     5295      +17     
  Lines        302570   303565     +995     
  Branches      44013    44152     +139     
============================================
+ Hits         217098   217616     +518     
- Misses        67315    67821     +506     
+ Partials      18157    18128      -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gbbafna gbbafna merged commit 4e5b7e5 into opensearch-project:2.x Oct 9, 2024
60 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants