Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deletion permits flow in RemoteFsTimestampAwareTranslog #16282

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Fix deletion permits flow in RemoteFsTimestampAwareTranslog #16282

merged 3 commits into from
Oct 15, 2024

Conversation

sachinpkale
Copy link
Member

@sachinpkale sachinpkale commented Oct 11, 2024 •
edited
Loading

Description

  • This PR is making change RemoteFsTranslog and RemoteFsTimestampAwareTranslog to ensure following:
    • Deletion permits are released when no longer required
    • More than REMOTE_DELETION_PERMITS are not available at any given point

Check List

  • Functionality includes testing.
  • [ ] API changes companion pull request created, if applicable.
  • [ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@sachinpkale
Fix deletion permits flow in RemoteFsTimestampAwareTranslog
e6a099a 
Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for e6a099a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@sachinpkale sachinpkale marked this pull request as ready for review October 11, 2024 08:24
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for e6a099a: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Oct 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 58.18182% with 23 lines in your changes missing coverage. Please review.

Project coverage is 72.04%. Comparing base (691f725) to head (541daa5).
Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
...index/translog/RemoteFsTimestampAwareTranslog.java 44.00% 14 Missing ⚠️
...dex/translog/transfer/TranslogTransferManager.java 79.16% 4 Missing and 1 partial ⚠️
...rg/opensearch/index/translog/RemoteFsTranslog.java 33.33% 4 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #16282      +/-   ##
============================================
- Coverage     72.06%   72.04%   -0.02%     
+ Complexity    64822    64812      -10     
============================================
  Files          5308     5308              
  Lines        302574   302604      +30     
  Branches      43710    43713       +3     
============================================
- Hits         218048   218017      -31     
- Misses        66648    66674      +26     
- Partials      17878    17913      +35

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sachinpkale
Add more tests
60c08be 
Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 60c08be: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 60c08be: SUCCESS

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Oct 11, 2024
Open
@sachinpkale
Address PR comments
541daa5 
Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 541daa5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

This was referenced Oct 15, 2024
Open
Open
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 541daa5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 541daa5: SUCCESS

ashking94
ashking94 approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@ashking94 ashking94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sachinpkale sachinpkale merged commit 23d1c7a into opensearch-project:main Oct 15, 2024
38 of 41 checks passed
@sachinpkale sachinpkale added the backport 2.x Backport to 2.x branch label Oct 15, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 15, 2024
@github-actions
Fix deletion permits flow in RemoteFsTimestampAwareTranslog (#16282)
ce20379 
---------

Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
(cherry picked from commit 23d1c7a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 15, 2024
Merged
This was referenced Oct 15, 2024
Open
Open
Open
dbwiddis pushed a commit that referenced this pull request Oct 16, 2024
@opensearch-trigger-bot @github-actions
Fix deletion permits flow in RemoteFsTimestampAwareTranslog (#16282) (#…
df52485 
…16336)

---------


(cherry picked from commit 23d1c7a)

Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
@sachinpkale @dk2k
Fix deletion permits flow in RemoteFsTimestampAwareTranslog (opensear…
a89d34a 
…ch-project#16282)

---------

Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
@sachinpkale @dk2k
Fix deletion permits flow in RemoteFsTimestampAwareTranslog (opensear…
0bbd19d 
…ch-project#16282)

---------

Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
@sachinpkale @dk2k
Fix deletion permits flow in RemoteFsTimestampAwareTranslog (opensear…
ce6ac6f 
…ch-project#16282)

---------

Signed-off-by: Sachin Kale <sachinpkale@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashking94 ashking94 ashking94 approved these changes

@dbwiddis dbwiddis dbwiddis approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sachinpkale @dbwiddis @ashking94