Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Make Remote Publication a dynamic setting (#15937) #16362

Merged

Conversation

shiv0408
Copy link
Member

cherry-pick 0c3e3c0 from #15937

* Make Remote Publication a dynamic setting

Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Co-authored-by: Sooraj Sinha <soosinha@amazon.com>
(cherry picked from commit 0c3e3c0)
Copy link
Contributor

❌ Gradle check result for 7f216a2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 0196250: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Shivansh Arora <hishiv@amazon.com>
@shiv0408 shiv0408 force-pushed the backport/backport-15937-to-2.x branch from 0196250 to 8403156 Compare October 17, 2024 10:09
Copy link
Contributor

❌ Gradle check result for 8403156: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 8403156: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@shiv0408
Copy link
Member Author

@shiv0408 shiv0408 closed this Oct 17, 2024
@shiv0408 shiv0408 reopened this Oct 17, 2024
Copy link
Contributor

✅ Gradle check result for 8403156: SUCCESS

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 72.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 71.85%. Comparing base (40e4a54) to head (8403156).
Report is 5 commits behind head on 2.x.

Files with missing lines Patch % Lines
...arch/gateway/remote/RemoteClusterStateService.java 66.66% 1 Missing and 5 partials ⚠️
...ting/remote/InternalRemoteRoutingTableService.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #16362      +/-   ##
============================================
+ Coverage     71.81%   71.85%   +0.04%     
- Complexity    65072    65100      +28     
============================================
  Files          5305     5304       -1     
  Lines        304056   304059       +3     
  Branches      44219    44219              
============================================
+ Hits         218356   218485     +129     
+ Misses        67500    67357     -143     
- Partials      18200    18217      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Bukhtawar Bukhtawar merged commit df6c12b into opensearch-project:2.x Oct 17, 2024
105 of 111 checks passed
@shiv0408 shiv0408 deleted the backport/backport-15937-to-2.x branch October 17, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants