[Backport 2.x] Fix array hashCode calculation in ResyncReplicationRequest (#16378) #16389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbwiddis
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
…h-project#16378) * Array, passed to Objects.hash(), should be wrapped into Arrays.hashCode(). Added unit test Signed-off-by: Dmitry Kryukov <dk2k@ya.ru> * Updated CHANGELOG.md Signed-off-by: Dmitry Kryukov <dk2k@ya.ru> --------- Signed-off-by: Dmitry Kryukov <dk2k@ya.ru>
dbwiddis
force-pushed
the
backport-16378-to-2.x
branch
from
7fad96c to
7c4c8ec
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #16389 +/- ##
============================================
- Coverage 71.78% 71.76% -0.02%
- Complexity 65079 65096 +17
============================================
Files 5305 5305
Lines 304146 304146
Branches 44232 44232
============================================
- Hits 218317 218268 -49
- Misses 67648 67706 +58
+ Partials 18181 18172 -9 ☔ View full report in Codecov by Sentry. |
dblock
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 0f7d572 from #16378