Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Fix typo super->sb in method toString() of RemoteStoreNodeAttribute(#15362) #16395

Merged
merged 2 commits into from
Oct 22, 2024
Merged

[Backport 2.x] Fix typo super->sb in method toString() of RemoteStoreNodeAttribute(#15362) #16395

merged 2 commits into from
Oct 22, 2024

Conversation

dbwiddis
Copy link
Member

Backport 0419e5d from #15362

@dbwiddis dbwiddis changed the title [Backport 2.x] Fix typo super->sb in method toString() of RemoteStoreNodeAttribute (… [Backport 2.x] Fix typo super->sb in method toString() of RemoteStoreNodeAttribute(#15362) Oct 21, 2024
@dk2k @dbwiddis
Fix typo super->sb in method toString() of RemoteStoreNodeAttribute (o…
b99a0ac 
…pensearch-project#15362)

* Removed unused StringBuilder

Signed-off-by: Dmitry Kryukov <dk2k@ya.ru>

* Restored lines, fixed typo super -> sb

Signed-off-by: Dmitry Kryukov <dk2k@ya.ru>

* Updated CHANGELOG.md

Signed-off-by: Dmitry Kryukov <dk2k@ya.ru>

---------

Signed-off-by: Dmitry Kryukov <dk2k@ya.ru>
@dbwiddis dbwiddis force-pushed the backport-15362-to-2.x branch from a82663b to b99a0ac Compare October 21, 2024 02:59
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for b99a0ac: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Oct 21, 2024
Open
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for b99a0ac: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Oct 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.84%. Comparing base (a31e7f2) to head (b202427).
Report is 7 commits behind head on 2.x.

Files with missing lines Patch % Lines
...rch/node/remotestore/RemoteStoreNodeAttribute.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #16395      +/-   ##
============================================
- Coverage     71.91%   71.84%   -0.07%     
- Complexity    65221    65230       +9     
============================================
  Files          5308     5308              
  Lines        304350   304350              
  Branches      44268    44268              
============================================
- Hits         218867   218661     -206     
- Misses        67234    67561     +327     
+ Partials      18249    18128     -121

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dblock
Copy link
Member

dblock commented Oct 21, 2024

Rebase?

@dbwiddis
Copy link
Member Author

Most of my manual backports are adding to thte end of the changelog (that's why the conflicted again) and can be easily resolved by any maintainer clicking "Resolve Conflicts" and editing the changelog appropriately (after CI runs completely again, we shouldn't rerun CI based only on a changelog update!)

@dbwiddis
Merge branch '2.x' into backport-15362-to-2.x
b202427 
Signed-off-by: Daniel Widdis <widdis@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for b202427: SUCCESS

@dbwiddis
Copy link
Member Author

dbwiddis commented Oct 22, 2024 •
edited
Loading

@dblock could I get a re-review? The merge conflict resolution invalidated your previous one. 2.18 code freeze coming up today and I've got a few pending manual backports....

@owaiskazi19 owaiskazi19 merged commit 89ed273 into opensearch-project:2.x Oct 22, 2024
37 of 39 checks passed
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Oct 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owaiskazi19 owaiskazi19 owaiskazi19 approved these changes

@dblock dblock dblock approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dbwiddis @dblock @owaiskazi19 @dk2k