Adds cluster setting to allow caching requests with size>0 in request cache #16484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
peteralfonsi
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
dbwiddis
reviewed
Oct 25, 2024
My mistake, I thought this was only for larger changes. I'll add it to the changelog. |
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
It may also need to be updated in the documentation. |
sgup432
reviewed
Oct 28, 2024
server/src/main/java/org/opensearch/indices/IndicesRequestCache.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/indices/IndicesService.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/indices/IndicesService.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
Signed-off-by: Peter Alfonsi <peter.alfonsi@gmail.com>
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
sgup432
reviewed
Oct 28, 2024
server/src/main/java/org/opensearch/indices/IndicesService.java
Outdated
Show resolved
Hide resolved
sgup432
reviewed
Oct 28, 2024
server/src/main/java/org/opensearch/indices/IndicesRequestCache.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
|
❌ Gradle check result for fe3818a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
|
❌ Gradle check result for c37b2bb: Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
github-actions
bot
added
enhancement
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
sgup432
approved these changes
Oct 29, 2024
1 task
dbwiddis
approved these changes
Nov 1, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 1, 2024
… cache (#16484) * Add cluster setting to allow size>0 in request cache Signed-off-by: Peter Alfonsi <petealft@amazon.com> * Add to changelog Signed-off-by: Peter Alfonsi <petealft@amazon.com> * addressed dbwiddis's comments Signed-off-by: Peter Alfonsi <petealft@amazon.com> * make canCacheSizeNonzeroRequests volatile Signed-off-by: Peter Alfonsi <petealft@amazon.com> * fix changelog merge Signed-off-by: Peter Alfonsi <petealft@amazon.com> * Changed setting name Signed-off-by: Peter Alfonsi <petealft@amazon.com> * more renaming Signed-off-by: Peter Alfonsi <petealft@amazon.com> * fix spotless check Signed-off-by: Peter Alfonsi <petealft@amazon.com> * rerun gradle check Signed-off-by: Peter Alfonsi <petealft@amazon.com> --------- Signed-off-by: Peter Alfonsi <petealft@amazon.com> Signed-off-by: Peter Alfonsi <peter.alfonsi@gmail.com> Co-authored-by: Peter Alfonsi <petealft@amazon.com> (cherry picked from commit 0363aa7) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Nov 1, 2024
… cache (#16484) (#16540) * Add cluster setting to allow size>0 in request cache * Add to changelog * addressed dbwiddis's comments * make canCacheSizeNonzeroRequests volatile * fix changelog merge * Changed setting name * more renaming * fix spotless check * rerun gradle check --------- (cherry picked from commit 0363aa7) Signed-off-by: Peter Alfonsi <petealft@amazon.com> Signed-off-by: Peter Alfonsi <peter.alfonsi@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Peter Alfonsi <petealft@amazon.com>
This was referenced Nov 5, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a cluster setting,
indices.requests.cache.enable_for_all_requests, which controls whether to allow caching requests withsize > 0in the request cache. Defaults to false, matching previous behavior.Since tiered caching can make the request cache significantly larger, it can make sense to cache these requests. This setting probably shouldn't be turned on if tiered caching isn't in use.
Tested in UT, IT, and manually tested turning the cluster setting on and off while checking whether requests were cached.
Related Issues
Resolves #16485
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.