Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Backport remote publication stats #16699

Merged

Conversation

himshikha
Copy link
Contributor

Description

Backport for #16682

Automated backport failing with codecov, adding more tests in this PR.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

himshikha and others added 2 commits November 21, 2024 22:25
…16682)

* Separating remote download and publication stats

Signed-off-by: Himshikha Gupta <himshikh@amazon.com>
Signed-off-by: Himshikha Gupta <himshikh@amazon.com>
Copy link
Contributor

❕ Gradle check result for b1f0ef1: UNSTABLE

  • TEST FAILURES:
      2 org.opensearch.cluster.MinimumClusterManagerNodesIT.testThreeNodesNoClusterManagerBlock

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 72.18045% with 37 lines in your changes missing coverage. Please review.

Project coverage is 71.84%. Comparing base (674edb0) to head (daa7535).
Report is 2 commits behind head on 2.x.

Files with missing lines Patch % Lines
...arch/gateway/remote/RemoteClusterStateService.java 72.95% 18 Missing and 15 partials ⚠️
...nsearch/gateway/remote/RemotePersistenceStats.java 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #16699      +/-   ##
============================================
- Coverage     71.91%   71.84%   -0.08%     
- Complexity    65434    65442       +8     
============================================
  Files          5314     5314              
  Lines        305217   305238      +21     
  Branches      44474    44475       +1     
============================================
- Hits         219500   219297     -203     
- Misses        67415    67721     +306     
+ Partials      18302    18220      -82     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Signed-off-by: Himshikha Gupta <himshikh@amazon.com>
Copy link
Contributor

✅ Gradle check result for 4b69810: SUCCESS

Signed-off-by: Himshikha Gupta <himshikh@amazon.com>
Copy link
Contributor

✅ Gradle check result for daa7535: SUCCESS

@Bukhtawar Bukhtawar merged commit 1b2c543 into opensearch-project:2.x Nov 25, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants