[Bugfix] Fix IllegalArgumentException thrown when creating a PIT

[peteralfonsi]

Description

Fixes java.lang.IllegalArgumentException: No enum constant org.opensearch.action.search.SearchPhaseName.CREATE_PIT which is thrown when creating a PIT.

The exception comes from SearchRequestStats. It doesn't track PIT stats as this is handled elsewhere. So, when it got search phases with the name "create_pit", it couldn't find a matching enum value and threw the error. Adds a try-catch block on search phase start/end/failure so that if no matching enum value is found, nothing happens.

Adds UTs. Also, manually tested that after making the change, the following commands no longer caused the exception:

curl -XPOST "http://localhost:9200/test-index/_doc/1?op_type=index" -H "Content-Type: application/json" -d '{ "field1": "value1", "field2": "value2", "field3": 123 }'

curl -XPOST "http://localhost:9200/test-index/_search/point_in_time?keep_alive=1h"

And confirmed the new catch-all doesn't show up in the output of curl -XGET "localhost:9200/_nodes/stats/indices/search".

Related Issues

Resolves #16750

Check List

• Functionality includes testing.
• API changes companion pull request created, if applicable.
• Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

❌ Gradle check result for 5824a3d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[peterzhuamazon]

Hi @peteralfonsi @andrross are we able to move forward with this PR?

opensearch-project/sql#3319 seens to be blocked by this.

Thanks.

[github-actions]

❌ Gradle check result for 2dd7b77: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 2dd7b77: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[peteralfonsi]

Flaky tests: #14297. Seems like it's failing to build the 2.19 linux tar, rerunning to see if it resolves

[github-actions]

❌ Gradle check result for 4a3906b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[andrross]

@peteralfonsi Can you rebase this PR with the latest from main?

[github-actions]

✅ Gradle check result for 521405a: SUCCESS

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-16781-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 56825f63ec19cd1b96651d0c5a3663108ee26c8e
# Push it to GitHub
git push --set-upstream origin backport/backport-16781-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-16781-to-2.x.