Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve value from DocValues in a flat_object filed #16802

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kkewwei
Copy link
Contributor

@kkewwei kkewwei commented Dec 8, 2024

Description

Added ability to retrieve value from DocValues in a flat_object filed

Related Issues

Resolves #16742

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request Indexing Indexing, Bulk Indexing and anything related to indexing Storage:Performance labels Dec 8, 2024
Copy link
Contributor

github-actions bot commented Dec 8, 2024

❌ Gradle check result for 31a060d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kkewwei kkewwei force-pushed the float_object_doc_value branch from 31a060d to 6054295 Compare December 8, 2024 20:57
Copy link
Contributor

github-actions bot commented Dec 8, 2024

❌ Gradle check result for 6054295: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kkewwei kkewwei force-pushed the float_object_doc_value branch from 6054295 to 5f51b30 Compare December 9, 2024 03:07
Copy link
Contributor

github-actions bot commented Dec 9, 2024

❌ Gradle check result for 5f51b30: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@msfroh
Copy link
Collaborator

msfroh commented Dec 11, 2024

@kkewwei -- I plan to review this PR this week. (Lots of meetings this week, but should have time Thursday or Friday.) Please @ me or bug me on OpenSearch Slack if I don't!

@kkewwei
Copy link
Contributor Author

kkewwei commented Dec 11, 2024

@kkewwei -- I plan to review this PR this week. (Lots of meetings this week, but should have time Thursday or Friday.) Please @ me or bug me on OpenSearch Slack if I don't!

Thank you very much, some of the unit tests are not ready, I will fix soon and at you when all is ready.

@kkewwei kkewwei force-pushed the float_object_doc_value branch from 5f51b30 to 218a8bb Compare December 11, 2024 12:16
Copy link
Contributor

❌ Gradle check result for 54cd837: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kkewwei kkewwei force-pushed the float_object_doc_value branch 2 times, most recently from c2e65ec to 4523b74 Compare December 11, 2024 13:57
Signed-off-by: kkewwei <kewei.11@bytedance.com>
Signed-off-by: kkewwei <kkewwei@163.com>
@kkewwei kkewwei force-pushed the float_object_doc_value branch from 4523b74 to a41d71e Compare December 11, 2024 14:04
@kkewwei
Copy link
Contributor Author

kkewwei commented Dec 11, 2024

❌ Gradle check result for 54cd837: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

SearchTimeoutIT.testSimpleTimeout #16056

@kkewwei
Copy link
Contributor Author

kkewwei commented Dec 11, 2024

@kkewwei -- I plan to review this PR this week. (Lots of meetings this week, but should have time Thursday or Friday.) Please @ me or bug me on OpenSearch Slack if I don't!

Thank you very much, some of the unit tests are not ready, I will fix soon and at you when all is ready.

TBR.

Copy link
Contributor

❕ Gradle check result for a41d71e: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 56.00000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 72.14%. Comparing base (5ba909a) to head (a41d71e).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...opensearch/index/mapper/FlatObjectFieldMapper.java 54.54% 7 Missing and 3 partials ⚠️
...a/org/opensearch/index/mapper/DocValueFetcher.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #16802      +/-   ##
============================================
+ Coverage     72.11%   72.14%   +0.03%     
- Complexity    65237    65306      +69     
============================================
  Files          5318     5318              
  Lines        304003   304034      +31     
  Branches      43992    43998       +6     
============================================
+ Hits         219228   219346     +118     
+ Misses        66874    66751     -123     
- Partials      17901    17937      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kkewwei
Copy link
Contributor Author

kkewwei commented Dec 12, 2024

❕ Gradle check result for a41d71e: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

SearchRestCancellationIT.testAutomaticCancellationDuringFetchPhase #14311

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Indexing Indexing, Bulk Indexing and anything related to indexing Storage:Performance
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[Feature Request] Retrieve value from DocValues in a flat_object filed
2 participants