Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Template query #16818

Merged
merged 7 commits into from
Jan 23, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
- Added a new `time` field to replace the deprecated `getTime` field in `GetStats`. ([#17009](https://github.com/opensearch-project/OpenSearch/pull/17009))
- Improve flat_object field parsing performance by reducing two passes to a single pass ([#16297](https://github.com/opensearch-project/OpenSearch/pull/16297))
- Improve performance of the bitmap filtering([#16936](https://github.com/opensearch-project/OpenSearch/pull/16936/))
- Introduce Template query ([#16818](https://github.com/opensearch-project/OpenSearch/pull/16818))

### Dependencies
- Bump `com.google.cloud:google-cloud-core-http` from 2.23.0 to 2.47.0 ([#16504](https://github.com/opensearch-project/OpenSearch/pull/16504))
Expand Down
1 change: 0 additions & 1 deletion server/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ dependencies {
api project(":libs:opensearch-telemetry")
api project(":libs:opensearch-task-commons")


compileOnly project(':libs:opensearch-plugin-classloader')
testRuntimeOnly project(':libs:opensearch-plugin-classloader')

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -476,7 +476,7 @@ private void executeRequest(
} else {
Rewriteable.rewriteAndFetch(
sr.source(),
searchService.getRewriteContext(timeProvider::getAbsoluteStartMillis),
searchService.getRewriteContext(timeProvider::getAbsoluteStartMillis, searchRequest),
rewriteListener
);
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,140 @@
/*
* SPDX-License-Identifier: Apache-2.0
*
* The OpenSearch Contributors require contributions made to
* this file be licensed under the Apache-2.0 license or a
* compatible open source license.
*/

package org.opensearch.index.query;

import org.opensearch.client.Client;
import org.opensearch.common.util.concurrent.CountDown;
import org.opensearch.core.action.ActionListener;
import org.opensearch.core.common.io.stream.NamedWriteableRegistry;
import org.opensearch.core.xcontent.NamedXContentRegistry;
import org.opensearch.core.xcontent.XContentParser;

import java.util.ArrayList;
import java.util.List;
import java.util.function.BiConsumer;
import java.util.function.LongSupplier;

/**
* BaseQueryRewriteContext is a base implementation of the QueryRewriteContext interface.
* It provides core functionality for query rewriting operations in OpenSearch.
*
* This class manages the context for query rewriting, including handling of asynchronous actions,
* access to content registries, and time-related operations.
*/
public class BaseQueryRewriteContext implements QueryRewriteContext {
dbwiddis marked this conversation as resolved.
Show resolved Hide resolved
private final NamedXContentRegistry xContentRegistry;
private final NamedWriteableRegistry writeableRegistry;
protected final Client client;
protected final LongSupplier nowInMillis;
private final List<BiConsumer<Client, ActionListener<?>>> asyncActions = new ArrayList<>();
private final boolean validate;

public BaseQueryRewriteContext(
NamedXContentRegistry xContentRegistry,
NamedWriteableRegistry writeableRegistry,
Client client,
LongSupplier nowInMillis
) {
this(xContentRegistry, writeableRegistry, client, nowInMillis, false);
}

public BaseQueryRewriteContext(
NamedXContentRegistry xContentRegistry,
NamedWriteableRegistry writeableRegistry,
Client client,
LongSupplier nowInMillis,
boolean validate
) {

this.xContentRegistry = xContentRegistry;
this.writeableRegistry = writeableRegistry;
this.client = client;
this.nowInMillis = nowInMillis;
this.validate = validate;
}

/**
* The registry used to build new {@link XContentParser}s. Contains registered named parsers needed to parse the query.
*/
public NamedXContentRegistry getXContentRegistry() {
return xContentRegistry;
}

/**
* Returns the time in milliseconds that is shared across all resources involved. Even across shards and nodes.
*/
public long nowInMillis() {
return nowInMillis.getAsLong();
}

public NamedWriteableRegistry getWriteableRegistry() {
return writeableRegistry;
}

/**
* Returns an instance of {@link QueryShardContext} if available of null otherwise
*/
public QueryShardContext convertToShardContext() {
return null;
}

/**
* Registers an async action that must be executed before the next rewrite round in order to make progress.
* This should be used if a rewriteabel needs to fetch some external resources in order to be executed ie. a document
* from an index.
*/
public void registerAsyncAction(BiConsumer<Client, ActionListener<?>> asyncAction) {
asyncActions.add(asyncAction);
}

/**
* Returns <code>true</code> if there are any registered async actions.
*/
public boolean hasAsyncActions() {
return asyncActions.isEmpty() == false;
}

/**
* Executes all registered async actions and notifies the listener once it's done. The value that is passed to the listener is always
* <code>null</code>. The list of registered actions is cleared once this method returns.
*/
public void executeAsyncActions(ActionListener listener) {
if (asyncActions.isEmpty()) {
listener.onResponse(null);
return;

Check warning on line 110 in server/src/main/java/org/opensearch/index/query/BaseQueryRewriteContext.java

View check run for this annotation

Codecov / codecov/patch

server/src/main/java/org/opensearch/index/query/BaseQueryRewriteContext.java#L109-L110

Added lines #L109 - L110 were not covered by tests
}

CountDown countDown = new CountDown(asyncActions.size());
dbwiddis marked this conversation as resolved.
Show resolved Hide resolved
ActionListener<?> internalListener = new ActionListener() {
@Override
public void onResponse(Object o) {
if (countDown.countDown()) {
listener.onResponse(null);
}
}

@Override
public void onFailure(Exception e) {
if (countDown.fastForward()) {
listener.onFailure(e);
}
}
};
// make a copy to prevent concurrent modification exception
List<BiConsumer<Client, ActionListener<?>>> biConsumers = new ArrayList<>(asyncActions);
asyncActions.clear();
dbwiddis marked this conversation as resolved.
Show resolved Hide resolved
for (BiConsumer<Client, ActionListener<?>> action : biConsumers) {
action.accept(client, internalListener);
}
}

public boolean validate() {
return validate;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@
import java.io.IOException;
import java.util.Collection;
import java.util.List;
import java.util.Map;

/**
* Utility class to create search queries.
Expand Down Expand Up @@ -780,4 +781,13 @@
public static ExistsQueryBuilder existsQuery(String name) {
return new ExistsQueryBuilder(name);
}

/**
* A query that contains a template with holder that should be resolved by search processors
*
* @param content The content of the template
*/
public static TemplateQueryBuilder templateQuery(Map<String, Object> content) {
return new TemplateQueryBuilder(content);

Check warning on line 791 in server/src/main/java/org/opensearch/index/query/QueryBuilders.java

View check run for this annotation

Codecov / codecov/patch

server/src/main/java/org/opensearch/index/query/QueryBuilders.java#L791

Added line #L791 was not covered by tests
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,93 @@
/*
* SPDX-License-Identifier: Apache-2.0
*
* The OpenSearch Contributors require contributions made to
* this file be licensed under the Apache-2.0 license or a
* compatible open source license.
*/

package org.opensearch.index.query;

import org.opensearch.client.Client;
import org.opensearch.common.annotation.PublicApi;
import org.opensearch.core.action.ActionListener;
import org.opensearch.core.common.io.stream.NamedWriteableRegistry;
import org.opensearch.core.xcontent.NamedXContentRegistry;
import org.opensearch.search.pipeline.PipelinedRequest;

import java.util.HashMap;
import java.util.Map;
import java.util.function.BiConsumer;

/**
* The QueryCoordinatorContext class implements the QueryRewriteContext interface and provides
* additional functionality for coordinating query rewriting in OpenSearch.
*
* This class acts as a wrapper around a QueryRewriteContext instance and a PipelinedRequest,
* allowing access to both rewrite context methods and pass over search request information.
*
* @since 2.19.0
*/
@PublicApi(since = "2.19.0")
public class QueryCoordinatorContext implements QueryRewriteContext {
private final QueryRewriteContext rewriteContext;
private final PipelinedRequest searchRequest;

public QueryCoordinatorContext(QueryRewriteContext rewriteContext, PipelinedRequest searchRequest) {
this.rewriteContext = rewriteContext;
this.searchRequest = searchRequest;
}

@Override
public NamedXContentRegistry getXContentRegistry() {
return rewriteContext.getXContentRegistry();

Check warning on line 43 in server/src/main/java/org/opensearch/index/query/QueryCoordinatorContext.java

View check run for this annotation

Codecov / codecov/patch

server/src/main/java/org/opensearch/index/query/QueryCoordinatorContext.java#L43

Added line #L43 was not covered by tests
}

@Override
public long nowInMillis() {
return rewriteContext.nowInMillis();

Check warning on line 48 in server/src/main/java/org/opensearch/index/query/QueryCoordinatorContext.java

View check run for this annotation

Codecov / codecov/patch

server/src/main/java/org/opensearch/index/query/QueryCoordinatorContext.java#L48

Added line #L48 was not covered by tests
}

@Override
public NamedWriteableRegistry getWriteableRegistry() {
return rewriteContext.getWriteableRegistry();

Check warning on line 53 in server/src/main/java/org/opensearch/index/query/QueryCoordinatorContext.java

View check run for this annotation

Codecov / codecov/patch

server/src/main/java/org/opensearch/index/query/QueryCoordinatorContext.java#L53

Added line #L53 was not covered by tests
}

@Override
public QueryShardContext convertToShardContext() {
return rewriteContext.convertToShardContext();
}

@Override
public void registerAsyncAction(BiConsumer<Client, ActionListener<?>> asyncAction) {
rewriteContext.registerAsyncAction(asyncAction);
}

@Override
public boolean hasAsyncActions() {
return rewriteContext.hasAsyncActions();
}

@Override
public void executeAsyncActions(ActionListener listener) {
rewriteContext.executeAsyncActions(listener);
}

@Override
public boolean validate() {
return rewriteContext.validate();

Check warning on line 78 in server/src/main/java/org/opensearch/index/query/QueryCoordinatorContext.java

View check run for this annotation

Codecov / codecov/patch

server/src/main/java/org/opensearch/index/query/QueryCoordinatorContext.java#L78

Added line #L78 was not covered by tests
}

@Override
public QueryCoordinatorContext convertToCoordinatorContext() {
return this;

Check warning on line 83 in server/src/main/java/org/opensearch/index/query/QueryCoordinatorContext.java

View check run for this annotation

Codecov / codecov/patch

server/src/main/java/org/opensearch/index/query/QueryCoordinatorContext.java#L83

Added line #L83 was not covered by tests
}

public Map<String, Object> getContextVariables() {

// Read from pipeline context
Map<String, Object> contextVariables = new HashMap<>(searchRequest.getPipelineProcessingContext().getAttributes());

Check warning on line 89 in server/src/main/java/org/opensearch/index/query/QueryCoordinatorContext.java

View check run for this annotation

Codecov / codecov/patch

server/src/main/java/org/opensearch/index/query/QueryCoordinatorContext.java#L89

Added line #L89 was not covered by tests

return contextVariables;

Check warning on line 91 in server/src/main/java/org/opensearch/index/query/QueryCoordinatorContext.java

View check run for this annotation

Codecov / codecov/patch

server/src/main/java/org/opensearch/index/query/QueryCoordinatorContext.java#L91

Added line #L91 was not covered by tests
}
}
Loading
Loading