[Flaky Test] Fix Flaky Test SearchTimeoutIT.testSimpleTimeout #16828
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When numDocs=1000:
testSimpleTimeout
will cost several minutes, when scoring each doc, it will cost 500ms, it's a long time to iterating all the doc inqueryphase
.OpenSearch/server/src/internalClusterTest/java/org/opensearch/search/SearchTimeoutIT.java
Line 138 in 5aa6509
ReaderContext
is created before executingqueryphase
and released after thefetchphase
.ReaderContext
is 1min(determined bysearch.keep_alive_interval
)queryPhase
costs too much time, theReaderContext
may be released beforefetchphase
, so thefetch/Id
will be failed, which hit the case.Related Issues
Resolves #16056 #9401
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.